You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/07/31 19:06:49 UTC

[kudu-CR] data dirs: clarify error message when all data dirs are full or failed 

Hello Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13969

to review the following change.


Change subject: data_dirs: clarify error message when all data dirs are full or failed
......................................................................

data_dirs: clarify error message when all data dirs are full or failed

The existing error message suggested that we tried (and failed) to add a
data directory to the tablet's data dir group when we did no such thing[1].

1. In the future we could do this; see KUDU-2907 for details.

Change-Id: I07fd860dcecf4f255f418b2063c1850eecbc6e65
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 20 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/13969/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07fd860dcecf4f255f418b2063c1850eecbc6e65
Gerrit-Change-Number: 13969
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR] data dirs: clarify error message when all data dirs are full or failed

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13969

to look at the new patch set (#2).

Change subject: data_dirs: clarify error message when all data dirs are full or failed
......................................................................

data_dirs: clarify error message when all data dirs are full or failed

The existing error message suggested that we tried (and failed) to add a
data directory to the tablet's data dir group when we did no such thing[1].

1. In the future we could do this; see KUDU-2907 for details.

Change-Id: I07fd860dcecf4f255f418b2063c1850eecbc6e65
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 21 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/13969/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07fd860dcecf4f255f418b2063c1850eecbc6e65
Gerrit-Change-Number: 13969
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] data dirs: clarify error message when all data dirs are full or failed

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13969 )

Change subject: data_dirs: clarify error message when all data dirs are full or failed
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07fd860dcecf4f255f418b2063c1850eecbc6e65
Gerrit-Change-Number: 13969
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 31 Jul 2019 19:55:54 +0000
Gerrit-HasComments: No

[kudu-CR] data dirs: clarify error message when all data dirs are full or failed

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13969 )

Change subject: data_dirs: clarify error message when all data dirs are full or failed
......................................................................

data_dirs: clarify error message when all data dirs are full or failed

The existing error message suggested that we tried (and failed) to add a
data directory to the tablet's data dir group when we did no such thing[1].

1. In the future we could do this; see KUDU-2907 for details.

Change-Id: I07fd860dcecf4f255f418b2063c1850eecbc6e65
Reviewed-on: http://gerrit.cloudera.org:8080/13969
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
2 files changed, 21 insertions(+), 13 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07fd860dcecf4f255f418b2063c1850eecbc6e65
Gerrit-Change-Number: 13969
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)