You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2026/03/25 12:29:22 UTC
(superset) 01/01: fix(embedded-sdk): wire `hideTab` to actually hide the dashboard tab (#38846)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 5.0-pulse
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 56877507cf3e487eec0ec57269de5e78bb7c29d2
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Wed Mar 25 09:19:56 2026 -0300
fix(embedded-sdk): wire `hideTab` to actually hide the dashboard tab (#38846)
(cherry picked from commit 3fb903fdc6ec094d35f89ce5c1b984dec8aa547d)
---
.../DashboardBuilder/DashboardBuilder.tsx | 52 ++++++++++++----------
1 file changed, 28 insertions(+), 24 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
index 66896bb5cc2..9f82e2b7f2b 100644
--- a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
+++ b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
@@ -533,30 +533,33 @@ const DashboardBuilder = () => {
/>
)}
{dropIndicatorProps && <div {...dropIndicatorProps} />}
- {!isReport && topLevelTabs && !uiConfig.hideNav && (
- <WithPopoverMenu
- shouldFocus={shouldFocusTabs}
- menuItems={[
- <IconButton
- icon={<Icons.FallOutlined iconSize="xl" />}
- label={t('Collapse tab content')}
- onClick={handleDeleteTopLevelTabs}
- />,
- ]}
- editMode={editMode}
- >
- {/* @ts-ignore */}
- <DashboardComponent
- id={topLevelTabs?.id}
- parentId={DASHBOARD_ROOT_ID}
- depth={DASHBOARD_ROOT_DEPTH + 1}
- index={0}
- renderTabContent={false}
- renderHoverMenu={false}
- onChangeTab={handleChangeTab}
- />
- </WithPopoverMenu>
- )}
+ {!isReport &&
+ topLevelTabs &&
+ !uiConfig.hideTab &&
+ !uiConfig.hideNav && (
+ <WithPopoverMenu
+ shouldFocus={shouldFocusTabs}
+ menuItems={[
+ <IconButton
+ icon={<Icons.FallOutlined iconSize="xl" />}
+ label={t('Collapse tab content')}
+ onClick={handleDeleteTopLevelTabs}
+ />,
+ ]}
+ editMode={editMode}
+ >
+ {/* @ts-ignore */}
+ <DashboardComponent
+ id={topLevelTabs?.id}
+ parentId={DASHBOARD_ROOT_ID}
+ depth={DASHBOARD_ROOT_DEPTH + 1}
+ index={0}
+ renderTabContent={false}
+ renderHoverMenu={false}
+ onChangeTab={handleChangeTab}
+ />
+ </WithPopoverMenu>
+ )}
</div>
),
[
@@ -568,6 +571,7 @@ const DashboardBuilder = () => {
hideDashboardHeader,
isReport,
topLevelTabs,
+ uiConfig.hideTab,
uiConfig.hideNav,
],
);