You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/14 09:00:25 UTC
[GitHub] [incubator-kyuubi] fsk119 opened a new pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
fsk119 opened a new pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Just throw the expected exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133#issuecomment-1066745293
@yaooqinn the failure of the CI isn't related to the changes of this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas edited a comment on pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133#issuecomment-1066745293
@yaooqinn @pan3793 @ulysses-you the failure of the CI isn't related to the changes of this pull request. Please help to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133#discussion_r825728241
##########
File path: externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/FlinkSQLOperationManager.scala
##########
@@ -110,7 +110,14 @@ class FlinkSQLOperationManager extends OperationManager("FlinkSQLOperationManage
catalogName: String,
schemaName: String,
tableName: String,
- columnName: String): Operation = null
+ columnName: String): Operation = {
+ throw new UnsupportedOperationException(String.format(
Review comment:
```suggestion
throw new UnsupportedOperationException(s"Unsupported Operation type: ${OperationType.GET_COLUMNS}. You can execute DESCRIBE statement instead to get columns.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133#issuecomment-1066574724
it conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on a change in pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on a change in pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133#discussion_r825728241
##########
File path: externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/FlinkSQLOperationManager.scala
##########
@@ -110,7 +110,14 @@ class FlinkSQLOperationManager extends OperationManager("FlinkSQLOperationManage
catalogName: String,
schemaName: String,
tableName: String,
- columnName: String): Operation = null
+ columnName: String): Operation = {
+ throw new UnsupportedOperationException(String.format(
Review comment:
```suggestion
throw new UnsupportedOperationException(s"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133#issuecomment-1067513498
thanks merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas removed a comment on pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133#issuecomment-1066745293
@yaooqinn @pan3793 @ulysses-you the failure of the CI isn't related to the changes of this pull request. Please help to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2133: [KYUUBI #2129] FlinkEngine throws UnsupportedOperationException in GetColumns
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #2133:
URL: https://github.com/apache/incubator-kyuubi/pull/2133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org