[GitHub] [james-project] chibenwa commented on a diff in pull request #1092: JAMES-3775 Write a webadmin route to feed spam to RSpamD

[GitBox <gi...@apache.org>]

chibenwa commented on code in PR #1092:
URL: https://github.com/apache/james-project/pull/1092#discussion_r934105485


##########
third-party/rspamd/README.md:
##########
@@ -0,0 +1,40 @@
+## Additional webadmin endpoints
+
+### Report spam messages to RSpamD
+One can use this route to schedule a task that reports spam messages to RSpamD for its spam classify learning.
+
+```bash
+curl -XPOST 'http://ip:port/rspamd?action=reportSpam
+```
+
+This endpoint has the following param:
+- `action` (required): need to be `reportSpam`
+- `messagesPerSecond` (optional): Concurrent learns performed for RSpamD, default to 10
+- `period` (optional): duration (in seconds), only messages between `now` and `now - duration` are reported. By default, 
+all messages are reported.

Review Comment:
   Please allow to provide unit. EG:
   
   `curl -XPOST 'http://ip:port/rspamd?action=reportSpam&period=1d`
   
   This makes it way more friendly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org