You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/30 02:41:58 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #3632: [bp-3614]arch/risc-v: Fix stack alignment according to calling convention

masayuki2009 commented on a change in pull request #3632:
URL: https://github.com/apache/incubator-nuttx/pull/3632#discussion_r623547862



##########
File path: arch/risc-v/src/k210/k210_head.S
##########
@@ -215,17 +215,17 @@ normal_irq:
  *  Name: g_intstackalloc and g_intstackbase
  ************************************************************************************/
 
-#if CONFIG_ARCH_INTERRUPTSTACK > 7
+#if CONFIG_ARCH_INTERRUPTSTACK > 15
   .bss
-  .align  8
+  .align  16
   .global g_intstackalloc
   .global g_intstackbase
   .type   g_intstackalloc, object
   .type   g_intstackbase, object
 g_intstackalloc:

Review comment:
       Sorry for the late reply but we need to apply similar logic to allocate stack for SMP as I did in https://github.com/apache/incubator-nuttx/pull/3518/files




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org