You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Alexander Rukletsov (JIRA)" <ji...@apache.org> on 2017/03/23 23:30:41 UTC

[jira] [Comment Edited] (MESOS-6906) Introduce a general non-interpreting task check.

    [ https://issues.apache.org/jira/browse/MESOS-6906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927024#comment-15927024 ] 

Alexander Rukletsov edited comment on MESOS-6906 at 3/23/17 11:29 PM:
----------------------------------------------------------------------

{noformat}
Commit: cc6e063a6907a282dac875133e9f328d5a6fd364 [cc6e063]
Author: Alexander Rukletsov <al...@apache.org>
Date: 7 March 2017 at 17:41:45 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Overloaded `<<` for `CheckInfo::Type`.

Review: https://reviews.apache.org/r/57394
{noformat}
{noformat}
Commit: f042bf607f9bdcf4d350df892b6985760a7ea7e8 [f042bf6]
Author: Alexander Rukletsov <al...@apache.org>
Date: 5 February 2017 at 21:53:51 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Updated checks library with general check support.

Add support for general checks, i.e. defined by CheckInfo, in
checking library. A general check can be either an command or
an HTTP request. The library performs the requested check at
the specified interval and sends the result to the framework
via a task status update. If the current result is the same as
the previous result, no status update is sent.

Review: https://reviews.apache.org/r/56208
{noformat}
{noformat}
Commit: a352bbfb057725429c9851a4d71f9aef07850816 [a352bbf]
Author: Alexander Rukletsov <al...@apache.org>
Date: 27 January 2017 at 17:48:55 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Reused previous task status for health updates in command executor.

When a new health task status update is generated in the executor, we
have to make sure specific data is duplicated from the previous one to
avoid shadowing of those data during reconciliation.

Review: https://reviews.apache.org/r/56210
{noformat}
{noformat}
Commit: 6b332ade085de92ba0ae29856e2b1990e4ea14b8 [6b332ad]
Author: Alexander Rukletsov <al...@apache.org>
Date: 27 January 2017 at 18:23:37 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Renamed health checker in command executor for clarity.

Review: https://reviews.apache.org/r/56211
{noformat}
{noformat}
Commit: a67231b004202a196370d6e6ea83fd75f76c7beb [a67231b]
Author: Alexander Rukletsov <al...@apache.org>
Date: 14 March 2017 at 12:36:09 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Kept TaskInfo beyond first scheduler ack in command executor.

Prior to this patch, command executor wipes TaskInfo after receiving
a status update acknowledgement from the scheduler to indicate that
there are no unacknowledged tasks. Keeping original TaskInfo beyond
the ack can be beneficial, hence we introduce a struct TaskData that
holds TaskInfo and explicit ack flag.

Review: https://reviews.apache.org/r/57596
{noformat}
{noformat}
Commit: 11160d6716d03865d2a74bad341d7ed33849385f [11160d6]
Author: Alexander Rukletsov <al...@apache.org>
Date: 28 February 2017 at 16:14:14 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Added support for general checks to command executor.

Review: https://reviews.apache.org/r/56212
{noformat}
{noformat}
Commit: 966833886efd9ba55b30c5ff225ce5691294e7bf [9668338]
Author: Alexander Rukletsov rukletsov@gmail.com
Date: 23 March 2017 at 17:11:40 GMT+1
Committer: Alexander Rukletsov alexr@apache.org
Commit Date: 24 March 2017 at 00:17:27 GMT+1

Added check tests for command executor.

Review: https://reviews.apache.org/r/56213/
{noformat}


was (Author: alexr):
{noformat}
Commit: cc6e063a6907a282dac875133e9f328d5a6fd364 [cc6e063]
Author: Alexander Rukletsov <al...@apache.org>
Date: 7 March 2017 at 17:41:45 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Overloaded `<<` for `CheckInfo::Type`.

Review: https://reviews.apache.org/r/57394
{noformat}
{noformat}
Commit: f042bf607f9bdcf4d350df892b6985760a7ea7e8 [f042bf6]
Author: Alexander Rukletsov <al...@apache.org>
Date: 5 February 2017 at 21:53:51 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Updated checks library with general check support.

Add support for general checks, i.e. defined by CheckInfo, in
checking library. A general check can be either an command or
an HTTP request. The library performs the requested check at
the specified interval and sends the result to the framework
via a task status update. If the current result is the same as
the previous result, no status update is sent.

Review: https://reviews.apache.org/r/56208
{noformat}
{noformat}
Commit: a352bbfb057725429c9851a4d71f9aef07850816 [a352bbf]
Author: Alexander Rukletsov <al...@apache.org>
Date: 27 January 2017 at 17:48:55 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Reused previous task status for health updates in command executor.

When a new health task status update is generated in the executor, we
have to make sure specific data is duplicated from the previous one to
avoid shadowing of those data during reconciliation.

Review: https://reviews.apache.org/r/56210
{noformat}
{noformat}
Commit: 6b332ade085de92ba0ae29856e2b1990e4ea14b8 [6b332ad]
Author: Alexander Rukletsov <al...@apache.org>
Date: 27 January 2017 at 18:23:37 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Renamed health checker in command executor for clarity.

Review: https://reviews.apache.org/r/56211
{noformat}
{noformat}
Commit: a67231b004202a196370d6e6ea83fd75f76c7beb [a67231b]
Author: Alexander Rukletsov <al...@apache.org>
Date: 14 March 2017 at 12:36:09 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Kept TaskInfo beyond first scheduler ack in command executor.

Prior to this patch, command executor wipes TaskInfo after receiving
a status update acknowledgement from the scheduler to indicate that
there are no unacknowledged tasks. Keeping original TaskInfo beyond
the ack can be beneficial, hence we introduce a struct TaskData that
holds TaskInfo and explicit ack flag.

Review: https://reviews.apache.org/r/57596
{noformat}
{noformat}
Commit: 11160d6716d03865d2a74bad341d7ed33849385f [11160d6]
Author: Alexander Rukletsov <al...@apache.org>
Date: 28 February 2017 at 16:14:14 GMT+1
Commit Date: 15 March 2017 at 22:20:20 GMT+1

Added support for general checks to command executor.

Review: https://reviews.apache.org/r/56212
{noformat}

> Introduce a general non-interpreting task check.
> ------------------------------------------------
>
>                 Key: MESOS-6906
>                 URL: https://issues.apache.org/jira/browse/MESOS-6906
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Alexander Rukletsov
>            Assignee: Alexander Rukletsov
>              Labels: health-check, mesosphere
>             Fix For: 1.3.0
>
>
> In addition to result-interpreting, killing health check, there is a requirement from Mesos framework authors for a general check that can execute an arbitrary command or send an HTTP request and pass the result to the scheduler without interpreting it.
> This ticket aims to implement this functionality by introducing a new class of a check in Mesos. Design doc: https://docs.google.com/document/d/1VLdaH7i7UDT3_38aOlzTOtH7lwH-laB8dCwNzte0DkU



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)