You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/07 09:55:47 UTC
[GitHub] [tvm] leandron opened a new pull request #8944: Add missing tvm.micro.project_api module file
leandron opened a new pull request #8944:
URL: https://github.com/apache/tvm/pull/8944
Add missing tvm.micro.project_api module file
* The missing __init__.py makes it impossible to `import tvm.micro.project_api`, which is indirectly done in `tvmc`
cc @tqchen @areusch @gromero @manupa-arm @Mousius for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #8944: Add missing tvm.micro.project_api module file
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8944:
URL: https://github.com/apache/tvm/pull/8944#issuecomment-914328254
uhhh weird how did that pass regression? very sorry about that! thanks for fixing the lint problems.
@gromero in general i'd expect most users to use tvm.micro.project, not tvm.micro.project_api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8944: Add missing tvm.micro.project_api module file
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8944:
URL: https://github.com/apache/tvm/pull/8944#issuecomment-914356989
> uhhh weird how did that pass regression? very sorry about that! thanks for fixing the lint problems.
Probably because it uses a source tree to run the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron closed pull request #8944: Add missing tvm.micro.project_api module file
Posted by GitBox <gi...@apache.org>.
leandron closed pull request #8944:
URL: https://github.com/apache/tvm/pull/8944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8944: Add missing tvm.micro.project_api module file
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8944:
URL: https://github.com/apache/tvm/pull/8944#issuecomment-914260578
> @areusch In general would an user (tvmc) import `tvm.micro.project_api` or import `tvm.micro.project` in order to create a new project using the Project API? I'm assuming the later form would be used. @leandron for the tvmc + micro targets work I'm doing https://github.com/gromero/tvm/blob/tvmc_micro_rb4/python/tvm/driver/tvmc/micro.py#L6 (`project` is already included in `__init__.py` of `micro` module) but you probably want it for a different use case?
When using it from a packaged `tvm`, i.e. `tlcpack`... this is a very small reproducer, that explains the need for this to be a module:
```
>>> from tvm.micro import export_model_library_format
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/a/lib/python3.6/site-packages/tvm/micro/__init__.py", line 21, in <module>
from .project import generate_project, GeneratedProject, TemplateProject
File "/a/lib/python3.6/site-packages/tvm/micro/project.py", line 27, in <module>
from .project_api import client
ModuleNotFoundError: No module named 'tvm.micro.project_api'
>>>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8944: Add missing tvm.micro.project_api module file
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8944:
URL: https://github.com/apache/tvm/pull/8944#issuecomment-914228043
Having this as a Python module now uncovered some 30-ish linter failures, I'm gonna fix them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #8944: Add missing tvm.micro.project_api module file
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #8944:
URL: https://github.com/apache/tvm/pull/8944#issuecomment-914237617
@areusch In general would an user (tvmc) import `tvm.micro.project_api` or import `tvm.micro.project` in order to create a new project using the Project API? I'm assuming the later form would be used. @leandron for the tvmc + micro targets work I'm doing https://github.com/gromero/tvm/blob/tvmc_micro_rb4/python/tvm/driver/tvmc/micro.py#L6 (`project` is already included in `__init__.py` of `micro` module) but you probably want it for a different use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org