[GitHub] [nifi-registry] kevdoran commented on a change in pull request #258: NIFIREG-358 Refactoring proxy authorization to be part of Authorizables

[GitBox <gi...@apache.org>]

kevdoran commented on a change in pull request #258: NIFIREG-358 Refactoring proxy authorization to be part of Authorizables
URL: https://github.com/apache/nifi-registry/pull/258#discussion_r382206875
 
 

 ##########
 File path: nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/security/authorization/resource/Authorizable.java
 ##########
 @@ -211,18 +205,10 @@ default void authorize(Authorizer authorizer, RequestAction action, NiFiUser use
             userContext = null;
         }
 
-        final List<String> proxyChain = new ArrayList<>();
-        NiFiUser proxyUser = user.getChain();
-        while (proxyUser  != null) {
-            proxyChain.add(proxyUser.getIdentity());
-            proxyUser = proxyUser.getChain();
-        }
 
 Review comment:
   Good question. I would not consider this a breaking change given that the provider processing the authorization request will have to make an authorization decision based on the information that is passed in, and the responsibility for authorizing proxies has been moved so that it is no longer a concern for the provider impls.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services