You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2024/09/22 07:05:23 UTC
[PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
yiguolei opened a new pull request, #41093:
URL: https://github.com/apache/doris/pull/41093
## Proposed changes
Sometimes if expr failed, then there will be a nullptr column left in the block.
We should ignore the nullptr column, or exception will be thrown and some profile will not computed correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41093:
URL: https://github.com/apache/doris/pull/41093#issuecomment-2365818502
<details>
<summary>TPC-H: <b>Total hot run time: 41238 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 18c84c90ba5dcf766bd04864f38a85561c527241, data reload: false
------ Round 1 ----------------------------------
q1 17574 7299 7281 7281
q2 2034 162 160 160
q3 10608 1071 1162 1071
q4 10454 666 722 666
q5 7734 3063 3102 3063
q6 236 151 149 149
q7 1024 625 624 624
q8 9451 2036 2058 2036
q9 6772 6400 6424 6400
q10 7060 2235 2296 2235
q11 441 260 246 246
q12 403 216 219 216
q13 17809 2938 3009 2938
q14 241 218 227 218
q15 569 522 520 520
q16 697 626 624 624
q17 973 808 799 799
q18 7224 6654 6592 6592
q19 1409 1000 992 992
q20 579 279 291 279
q21 4580 3298 3133 3133
q22 1100 1016 996 996
Total cold run time: 108972 ms
Total hot run time: 41238 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7252 7307 7268 7268
q2 332 226 226 226
q3 3012 2967 2989 2967
q4 2074 1812 1862 1812
q5 5583 5585 5592 5585
q6 243 151 148 148
q7 2183 1786 1791 1786
q8 3284 3441 3395 3395
q9 8805 8846 8741 8741
q10 3514 3407 3493 3407
q11 589 460 472 460
q12 817 624 610 610
q13 9654 3204 3187 3187
q14 316 285 271 271
q15 578 528 519 519
q16 702 675 701 675
q17 1803 1624 1564 1564
q18 8144 7883 7720 7720
q19 1709 1536 1614 1536
q20 2108 1895 1888 1888
q21 5490 5389 5344 5344
q22 1136 1044 1068 1044
Total cold run time: 69328 ms
Total hot run time: 60153 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41093:
URL: https://github.com/apache/doris/pull/41093#issuecomment-2365885944
<details>
<summary>TPC-DS: <b>Total hot run time: 194383 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 18c84c90ba5dcf766bd04864f38a85561c527241, data reload: false
query1 1226 880 914 880
query2 6377 2025 2061 2025
query3 10778 3862 3862 3862
query4 63895 27684 23418 23418
query5 5038 482 496 482
query6 415 172 172 172
query7 5449 308 304 304
query8 313 227 221 221
query9 8429 2663 2680 2663
query10 482 281 274 274
query11 17320 15175 15735 15175
query12 154 111 101 101
query13 1469 420 419 419
query14 10823 6864 7285 6864
query15 203 181 168 168
query16 6763 492 505 492
query17 1192 601 582 582
query18 1327 304 306 304
query19 220 156 154 154
query20 124 115 117 115
query21 206 104 103 103
query22 4788 4273 4621 4273
query23 34484 34039 33991 33991
query24 6000 2968 2863 2863
query25 515 408 414 408
query26 619 158 159 158
query27 1597 282 289 282
query28 4388 2468 2430 2430
query29 675 434 427 427
query30 236 162 156 156
query31 986 790 789 789
query32 75 53 56 53
query33 432 282 304 282
query34 882 504 483 483
query35 871 745 724 724
query36 1068 931 913 913
query37 145 86 91 86
query38 3940 3988 3924 3924
query39 1487 1407 1465 1407
query40 201 97 95 95
query41 50 49 50 49
query42 119 98 102 98
query43 543 496 495 495
query44 1139 823 817 817
query45 194 167 165 165
query46 1146 772 788 772
query47 1896 1828 1842 1828
query48 464 353 365 353
query49 689 386 381 381
query50 830 403 406 403
query51 7182 7069 6855 6855
query52 100 84 84 84
query53 248 175 176 175
query54 578 446 451 446
query55 74 74 73 73
query56 269 260 259 259
query57 1246 1080 1103 1080
query58 224 235 230 230
query59 3165 3056 3036 3036
query60 287 270 272 270
query61 103 100 101 100
query62 764 680 658 658
query63 218 179 185 179
query64 1295 654 600 600
query65 3246 3249 3179 3179
query66 673 297 299 297
query67 16080 15753 15437 15437
query68 4327 598 568 568
query69 699 400 326 326
query70 1168 1114 1158 1114
query71 500 266 272 266
query72 7637 3804 4056 3804
query73 789 324 331 324
query74 9641 8943 8990 8943
query75 3888 2622 2692 2622
query76 3586 891 928 891
query77 738 285 288 285
query78 9900 9119 9153 9119
query79 1785 538 547 538
query80 833 460 435 435
query81 555 241 246 241
query82 245 139 138 138
query83 325 139 143 139
query84 289 80 80 80
query85 896 288 282 282
query86 383 302 287 287
query87 4454 4225 4283 4225
query88 3710 2307 2332 2307
query89 399 296 280 280
query90 2244 187 188 187
query91 198 142 143 142
query92 59 48 47 47
query93 2473 549 548 548
query94 890 296 288 288
query95 343 260 254 254
query96 614 284 277 277
query97 3261 3111 3125 3111
query98 213 206 190 190
query99 1748 1291 1284 1284
Total cold run time: 317204 ms
Total hot run time: 194383 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41093:
URL: https://github.com/apache/doris/pull/41093#issuecomment-2365635048
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #41093:
URL: https://github.com/apache/doris/pull/41093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41093:
URL: https://github.com/apache/doris/pull/41093#issuecomment-2365913073
<details>
<summary>ClickBench: <b>Total hot run time: 33.39 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 18c84c90ba5dcf766bd04864f38a85561c527241, data reload: false
query1 0.05 0.04 0.05
query2 0.06 0.03 0.03
query3 0.23 0.06 0.06
query4 1.65 0.10 0.09
query5 0.52 0.50 0.50
query6 1.13 0.72 0.72
query7 0.01 0.01 0.01
query8 0.04 0.03 0.03
query9 0.56 0.50 0.51
query10 0.54 0.56 0.53
query11 0.14 0.10 0.10
query12 0.14 0.11 0.11
query13 0.60 0.59 0.60
query14 2.98 3.10 2.97
query15 0.90 0.83 0.82
query16 0.39 0.39 0.38
query17 1.04 1.05 1.03
query18 0.20 0.18 0.19
query19 1.97 1.91 1.98
query20 0.01 0.01 0.01
query21 15.36 0.60 0.59
query22 2.51 2.73 2.33
query23 17.35 0.75 0.74
query24 2.88 1.08 1.59
query25 0.29 0.05 0.24
query26 0.35 0.13 0.14
query27 0.04 0.05 0.03
query28 10.35 1.09 1.06
query29 12.55 3.25 3.23
query30 0.24 0.05 0.07
query31 3.18 0.38 0.39
query32 3.54 0.47 0.47
query33 3.06 3.00 3.05
query34 16.77 4.40 4.43
query35 4.41 4.46 4.47
query36 0.67 0.48 0.48
query37 0.08 0.06 0.05
query38 0.04 0.04 0.03
query39 0.04 0.02 0.02
query40 0.16 0.13 0.12
query41 0.07 0.02 0.02
query42 0.03 0.02 0.03
query43 0.03 0.04 0.04
Total cold run time: 107.16 s
Total hot run time: 33.39 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #41093:
URL: https://github.com/apache/doris/pull/41093#issuecomment-2365635147
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41093:
URL: https://github.com/apache/doris/pull/41093#issuecomment-2367064470
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41093:
URL: https://github.com/apache/doris/pull/41093#issuecomment-2367064485
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [bugfix](allocatebytes) ignore null ptr column in Block [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41093:
URL: https://github.com/apache/doris/pull/41093#issuecomment-2365794261
TeamCity be ut coverage result:
Function Coverage: 37.27% (9604/25772)
Line Coverage: 28.66% (79463/277229)
Region Coverage: 28.11% (41094/146195)
Branch Coverage: 24.75% (20947/84638)
Coverage Report: http://coverage.selectdb-in.cc/coverage/18c84c90ba5dcf766bd04864f38a85561c527241_18c84c90ba5dcf766bd04864f38a85561c527241/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org