You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sadikovi (via GitHub)" <gi...@apache.org> on 2023/03/29 23:18:35 UTC

[GitHub] [spark] sadikovi commented on a diff in pull request #36677: [SPARK-39296][CORE][SQL] Replcace `Array.toString` with `Array.mkString`

sadikovi commented on code in PR #36677:
URL: https://github.com/apache/spark/pull/36677#discussion_r1152581161


##########
core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala:
##########
@@ -516,7 +516,8 @@ private[deploy] class Worker(
         val cleanupFuture: concurrent.Future[Unit] = concurrent.Future {
           val appDirs = workDir.listFiles()
           if (appDirs == null) {
-            throw new IOException("ERROR: Failed to list files in " + appDirs)
+            throw new IOException(
+              s"ERROR: Failed to list files in ${appDirs.mkString("dirs(", ", ", ")")}")

Review Comment:
   @LuciferYang This will cause a NullPointerException error because appDirs is null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org