You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Antoine Toulme (JIRA)" <ji...@apache.org> on 2010/03/24 03:26:27 UTC
[jira] Created: (BUILDR-406) Support for regexps in include and
exclude patterns
Support for regexps in include and exclude patterns
---------------------------------------------------
Key: BUILDR-406
URL: https://issues.apache.org/jira/browse/BUILDR-406
Project: Buildr
Issue Type: Improvement
Components: Core features
Affects Versions: 1.3.5
Reporter: Antoine Toulme
Fix For: 1.4
The filter class lets people set patterns for including or excluding elements from a package, a zip, etc.
We currently support glob like patterns. It would be great to also support regular expressions.
The plan would be to let users define include or exclude patterns using regular expressions that way:
package(:zip).exclude(/\.*/)
package(:zip).include(/[C|D][0-9]*/)
Strings will still be used as glob patterns, so both mechanisms can complete each other:
package(:zip).exclude("target").include(/test-.*\.html/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-406) Support for regexps in include and
exclude patterns
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-406.
-----------------------------------
Resolution: Fixed
Thanks for the review Alex.
11:42:47~/w/buildr>svn ci CHANGELOG spec lib/buildr/core/filter.rb -m "fix for BUILDR-406: Support for regexps in include and exclude patterns"
Sending CHANGELOG
Sending lib/buildr/core/filter.rb
Sending spec/core/common_spec.rb
Transmitting file data ...
Committed revision 927147.
> Support for regexps in include and exclude patterns
> ---------------------------------------------------
>
> Key: BUILDR-406
> URL: https://issues.apache.org/jira/browse/BUILDR-406
> Project: Buildr
> Issue Type: Improvement
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
> Assignee: Antoine Toulme
> Fix For: 1.4
>
> Attachments: BUILDR-406.txt
>
>
> The filter class lets people set patterns for including or excluding elements from a package, a zip, etc.
> We currently support glob like patterns. It would be great to also support regular expressions.
> The plan would be to let users define include or exclude patterns using regular expressions that way:
> package(:zip).exclude(/\.*/)
> package(:zip).include(/[C|D][0-9]*/)
> Strings will still be used as glob patterns, so both mechanisms can complete each other:
> package(:zip).exclude("target").include(/test-.*\.html/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BUILDR-406) Support for regexps in include and
exclude patterns
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme reassigned BUILDR-406:
-------------------------------------
Assignee: Antoine Toulme
> Support for regexps in include and exclude patterns
> ---------------------------------------------------
>
> Key: BUILDR-406
> URL: https://issues.apache.org/jira/browse/BUILDR-406
> Project: Buildr
> Issue Type: Improvement
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
> Assignee: Antoine Toulme
> Fix For: 1.4
>
>
> The filter class lets people set patterns for including or excluding elements from a package, a zip, etc.
> We currently support glob like patterns. It would be great to also support regular expressions.
> The plan would be to let users define include or exclude patterns using regular expressions that way:
> package(:zip).exclude(/\.*/)
> package(:zip).include(/[C|D][0-9]*/)
> Strings will still be used as glob patterns, so both mechanisms can complete each other:
> package(:zip).exclude("target").include(/test-.*\.html/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-406) Support for regexps in include and
exclude patterns
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated BUILDR-406:
----------------------------------
Attachment: BUILDR-406.txt
Here is a patch with specs that does the job.
I'll let it simmer for a little bit and will commit unless a red flag is raised.
> Support for regexps in include and exclude patterns
> ---------------------------------------------------
>
> Key: BUILDR-406
> URL: https://issues.apache.org/jira/browse/BUILDR-406
> Project: Buildr
> Issue Type: Improvement
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
> Assignee: Antoine Toulme
> Fix For: 1.4
>
> Attachments: BUILDR-406.txt
>
>
> The filter class lets people set patterns for including or excluding elements from a package, a zip, etc.
> We currently support glob like patterns. It would be great to also support regular expressions.
> The plan would be to let users define include or exclude patterns using regular expressions that way:
> package(:zip).exclude(/\.*/)
> package(:zip).include(/[C|D][0-9]*/)
> Strings will still be used as glob patterns, so both mechanisms can complete each other:
> package(:zip).exclude("target").include(/test-.*\.html/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-406) Support for regexps in include and
exclude patterns
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849054#action_12849054 ]
Alex Boisvert commented on BUILDR-406:
--------------------------------------
I reviewed quickly and I don't see anything that could harm so I'd say commit it!
> Support for regexps in include and exclude patterns
> ---------------------------------------------------
>
> Key: BUILDR-406
> URL: https://issues.apache.org/jira/browse/BUILDR-406
> Project: Buildr
> Issue Type: Improvement
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
> Assignee: Antoine Toulme
> Fix For: 1.4
>
> Attachments: BUILDR-406.txt
>
>
> The filter class lets people set patterns for including or excluding elements from a package, a zip, etc.
> We currently support glob like patterns. It would be great to also support regular expressions.
> The plan would be to let users define include or exclude patterns using regular expressions that way:
> package(:zip).exclude(/\.*/)
> package(:zip).include(/[C|D][0-9]*/)
> Strings will still be used as glob patterns, so both mechanisms can complete each other:
> package(:zip).exclude("target").include(/test-.*\.html/)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.