You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2005/01/10 08:11:34 UTC
Re: svn commit: r124599 - /httpd/httpd/trunk/modules/config5.m4
Please describe what this actually does?
Are we back to libproxy.la, libssl.la after this change?
At 07:57 PM 1/7/2005, erikabele@apache.org wrote:
>Author: erikabele
>Date: Fri Jan 7 17:57:26 2005
>New Revision: 124599
>
>URL: http://svn.apache.org/viewcvs?view=rev&rev=124599
>Log:
>For a static module, use a filename with a lib prefix,
>see also rev 102381 of acinclude.m4
>
>
>Modified:
> httpd/httpd/trunk/modules/config5.m4
>
>Modified: httpd/httpd/trunk/modules/config5.m4
>Url: http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/config5.m4?view=diff&rev=124599&p1=httpd/httpd/trunk/modules/config5.m4&r1=124598&p2=httpd/httpd/trunk/modules/config5.m4&r2=124599
>==============================================================================
>--- httpd/httpd/trunk/modules/config5.m4 (original)
>+++ httpd/httpd/trunk/modules/config5.m4 Fri Jan 7 17:57:26 2005
>@@ -13,7 +13,8 @@
> fi
> module=`echo $pkg | sed -e 's;.*/mod_\(.*\).c;\1;'`
> objects="mod_$module.lo"
>- libname="mod_$module.la"
>+ # The filename of a convenience library must have a "lib" prefix:
>+ libname="lib$module.la"
> modpath_current="modules/$modtype"
> BUILTIN_LIBS="$BUILTIN_LIBS $modpath_current/$libname"
> if test ! -s "$modpath_current/modules.mk"; then
Re: svn commit: r124599 - /httpd/httpd/trunk/modules/config5.m4
Posted by Erik Abele <er...@codefaktor.de>.
On 25.01.2005, at 15:21, Joe Orton wrote:
> On Tue, Jan 25, 2005 at 02:09:06PM +0100, Erik Abele wrote:
>> Exactly, this just keeps --with-module consistent with the rest of the
>> build system, in respect to the changes introduced by Joe. (Sorry,
>> Bill, I somehow missed your original mail...)
>
> Actually it doesn't, there was a subsequent change to use "libmod_*.la"
> for statically-linked modules, since creating a "libfoo.la" which is
> linked against a "-lfoo" confuses libtool.
Correct, I somehow missed r103164:
- libname="lib$1.la"
+ libname="libmod_$1.la"
Will fix this ASAP...
> On 2.0 statically-linked
> modules still use filenames like "mod_*.la", so it's not consistent
> with
> that either ;)
Also correct and of course doesn't make sense without your changes.
Will remove the backport vote.
> I wasn't sure: what motivated your change, just consistency? My
> changes
> were made to fix issues using as-yet-unreleased versions of libtool.
While extending --with-module I experienced problems like 'The filename
of a convenience library must have a "lib" prefix' when building
modules on OS X with libtool-1.5.10, the solution was obviously the
change from r102381...
Cheers,
Erik
Re: svn commit: r124599 - /httpd/httpd/trunk/modules/config5.m4
Posted by Joe Orton <jo...@redhat.com>.
On Tue, Jan 25, 2005 at 02:09:06PM +0100, Erik Abele wrote:
> On 23.01.2005, at 18:43, Justin Erenkrantz wrote:
>
> >On Mon, Jan 10, 2005 at 01:11:34AM -0600, William A. Rowe, Jr. wrote:
> >>Please describe what this actually does?
> >>
> >>Are we back to libproxy.la, libssl.la after this change?
> >
> >For static modules, yes. This was modified in r102381 by Joe:
> >
> >---
> >Correct use of libtool: libtool convenience libraries which are to be
> >linked directly into a program must be linked using -static and not
> >-module. Fixes build issues with libtool HEAD.
> >---
> >
> >Erik's change just catches up the manual modules to this change. --
> >justin
>
> Exactly, this just keeps --with-module consistent with the rest of the
> build system, in respect to the changes introduced by Joe. (Sorry,
> Bill, I somehow missed your original mail...)
Actually it doesn't, there was a subsequent change to use "libmod_*.la"
for statically-linked modules, since creating a "libfoo.la" which is
linked against a "-lfoo" confuses libtool. On 2.0 statically-linked
modules still use filenames like "mod_*.la", so it's not consistent with
that either ;)
I wasn't sure: what motivated your change, just consistency? My changes
were made to fix issues using as-yet-unreleased versions of libtool.
joe
Re: svn commit: r124599 - /httpd/httpd/trunk/modules/config5.m4
Posted by Erik Abele <er...@codefaktor.de>.
On 23.01.2005, at 18:43, Justin Erenkrantz wrote:
> On Mon, Jan 10, 2005 at 01:11:34AM -0600, William A. Rowe, Jr. wrote:
>> Please describe what this actually does?
>>
>> Are we back to libproxy.la, libssl.la after this change?
>
> For static modules, yes. This was modified in r102381 by Joe:
>
> ---
> Correct use of libtool: libtool convenience libraries which are to be
> linked directly into a program must be linked using -static and not
> -module. Fixes build issues with libtool HEAD.
> ---
>
> Erik's change just catches up the manual modules to this change. --
> justin
Exactly, this just keeps --with-module consistent with the rest of the
build system, in respect to the changes introduced by Joe. (Sorry,
Bill, I somehow missed your original mail...)
Cheers,
Erik
Re: svn commit: r124599 - /httpd/httpd/trunk/modules/config5.m4
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Mon, Jan 10, 2005 at 01:11:34AM -0600, William A. Rowe, Jr. wrote:
> Please describe what this actually does?
>
> Are we back to libproxy.la, libssl.la after this change?
For static modules, yes. This was modified in r102381 by Joe:
---
Correct use of libtool: libtool convenience libraries which are to be
linked directly into a program must be linked using -static and not
-module. Fixes build issues with libtool HEAD.
---
Erik's change just catches up the manual modules to this change. -- justin
Re: svn commit: r124599 - /httpd/httpd/trunk/modules/config5.m4
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Mon, Jan 10, 2005 at 01:11:34AM -0600, William A. Rowe, Jr. wrote:
> Please describe what this actually does?
>
> Are we back to libproxy.la, libssl.la after this change?
For static modules, yes. This was modified in r102381 by Joe:
---
Correct use of libtool: libtool convenience libraries which are to be
linked directly into a program must be linked using -static and not
-module. Fixes build issues with libtool HEAD.
---
Erik's change just catches up the manual modules to this change. -- justin