You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2018/09/17 21:37:14 UTC
[Impala-ASF-CR] IMPALA-7580: Increase timeout int test automatic invalidation
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11453
Change subject: IMPALA-7580: Increase timeout int test_automatic_invalidation
......................................................................
IMPALA-7580: Increase timeout int test_automatic_invalidation
The query in test_automatic_invalidation might finish after the table
expires and renders the test flaky. This patch increases the timeout to
10 seconds on regular builds and 20 seconds on slow builds.
Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
---
M tests/custom_cluster/test_automatic_invalidation.py
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/11453/1
--
To view, visit http://gerrit.cloudera.org:8080/11453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
Gerrit-Change-Number: 11453
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7580: Increase timeout int test automatic invalidation
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11453 )
Change subject: IMPALA-7580: Increase timeout int test_automatic_invalidation
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
Gerrit-Change-Number: 11453
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 23:07:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7580: Increase timeout int test automatic invalidation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11453 )
Change subject: IMPALA-7580: Increase timeout int test_automatic_invalidation
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/697/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
Gerrit-Change-Number: 11453
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 22:24:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7580: Increase timeout int test automatic invalidation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11453 )
Change subject: IMPALA-7580: Increase timeout int test_automatic_invalidation
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3168/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
Gerrit-Change-Number: 11453
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 23:08:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7580: Increase timeout int test automatic invalidation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11453 )
Change subject: IMPALA-7580: Increase timeout int test_automatic_invalidation
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
Gerrit-Change-Number: 11453
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Sep 2018 02:47:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7580: Increase timeout int test automatic invalidation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11453 )
Change subject: IMPALA-7580: Increase timeout int test_automatic_invalidation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
Gerrit-Change-Number: 11453
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 23:08:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7580: Increase timeout int test automatic invalidation
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11453 )
Change subject: IMPALA-7580: Increase timeout int test_automatic_invalidation
......................................................................
IMPALA-7580: Increase timeout int test_automatic_invalidation
The query in test_automatic_invalidation might finish after the table
expires and renders the test flaky. This patch increases the timeout to
10 seconds on regular builds and 20 seconds on slow builds.
Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
Reviewed-on: http://gerrit.cloudera.org:8080/11453
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_automatic_invalidation.py
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcf8fabdbfedf310b452bbc9b913a0a85c4b18f1
Gerrit-Change-Number: 11453
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>