You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/01/28 18:22:13 UTC
[Impala-ASF-CR] IMPALA-8093: Profiles prefix counters inconsistently
ychen@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12287
Change subject: IMPALA-8093: Profiles prefix counters inconsistently
......................................................................
IMPALA-8093: Profiles prefix counters inconsistently
Change-Id: I7184bc69c2816a9721390bcf424a549321a88b2f
---
M be/src/util/runtime-profile.cc
M tests/query_test/test_runtime_filters.py
2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/12287/1
--
To view, visit http://gerrit.cloudera.org:8080/12287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7184bc69c2816a9721390bcf424a549321a88b2f
Gerrit-Change-Number: 12287
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-8093: Profiles prefix counters inconsistently
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12287 )
Change subject: IMPALA-8093: Profiles prefix counters inconsistently
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12287/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12287/1//COMMIT_MSG@7
PS1, Line 7: Profiles prefix counters inconsistently
We usually include what the patch does rather than the description of the bug itself. Something like, "Prefix time series counters with a hyphen"
http://gerrit.cloudera.org:8080/#/c/12287/1/tests/query_test/test_runtime_filters.py
File tests/query_test/test_runtime_filters.py:
http://gerrit.cloudera.org:8080/#/c/12287/1/tests/query_test/test_runtime_filters.py@72
PS1, Line 72: if re.search(" MemoryUsage", result.runtime_profile) is not None:
: # MemoryUsage is a Time series counter, it should start with " - ", not " "
: assert re.search(" MemoryUsage", result.runtime_profile) is None
: assert re.search("- MemoryUsage", result.runtime_profile) is not None
Seems out of place here. I'd guess this is a good candidate for test_observability.py. Lars, what do you think?
--
To view, visit http://gerrit.cloudera.org:8080/12287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7184bc69c2816a9721390bcf424a549321a88b2f
Gerrit-Change-Number: 12287
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 00:47:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8093: Profiles prefix counters inconsistently
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12287 )
Change subject: IMPALA-8093: Profiles prefix counters inconsistently
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1907/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7184bc69c2816a9721390bcf424a549321a88b2f
Gerrit-Change-Number: 12287
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 19:16:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8093: Profiles prefix counters inconsistently
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has abandoned this change. ( http://gerrit.cloudera.org:8080/12287 )
Change subject: IMPALA-8093: Profiles prefix counters inconsistently
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/12287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I7184bc69c2816a9721390bcf424a549321a88b2f
Gerrit-Change-Number: 12287
Gerrit-PatchSet: 1
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>