You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/06/28 19:06:03 UTC
[Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7321
Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................
IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
To support Kudu timestamps, Impala sets a KuduScanner flag
which pads the result tuples:
KuduScanner::PAD_UNIXTIME_MICROS_TO_16_BYTES
It is always set, which is correct, but means that newer
versions of Impala cannot scan older Kudus even if there are
no TIMESTAMP columns.
Even though Impala provides no guarantees about supporting
older versions of Kudu (i.e. there is no testing), the flag
should just be set when there are TIMESTAMP columns since
this is a known incompatibility that is easy to work around
for users who are still willing to use unsupported setups.
Testing:
This works against the current version of Kudu (the only
supported configuration).
Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
---
M be/src/exec/kudu-scanner.cc
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/7321/1
--
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/800/
--
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................
Patch Set 1: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/800/
--
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/805/
--
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................
IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
To support Kudu timestamps, Impala sets a KuduScanner flag
which pads the result tuples:
KuduScanner::PAD_UNIXTIME_MICROS_TO_16_BYTES
It is always set, which is correct, but means that newer
versions of Impala cannot scan older Kudus even if there are
no TIMESTAMP columns.
Even though Impala provides no guarantees about supporting
older versions of Kudu (i.e. there is no testing), the flag
should just be set when there are TIMESTAMP columns since
this is a known incompatibility that is easy to work around
for users who are still willing to use unsupported setups.
Testing:
This works against the current version of Kudu (the only
supported configuration).
Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Reviewed-on: http://gerrit.cloudera.org:8080/7321
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/kudu-scanner.cc
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Matthew Jacobs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>