You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/16 02:56:32 UTC
Review Request 16939: Added UNREACHABLE to stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16939/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Niklas Nielsen, TILL TOENSHOFF, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary, this is used in libprocess to silence a warning from clang.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 0725722ed99695ebe6d2410c4704d6f1b8d0ff7f
3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/16939/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 16939: Added UNREACHABLE to stout.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16939/#review31996
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 16, 2014, 1:56 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16939/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 1:56 a.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, TILL TOENSHOFF, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary, this is used in libprocess to silence a warning from clang.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0725722ed99695ebe6d2410c4704d6f1b8d0ff7f
> 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16939/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 16939: Added UNREACHABLE to stout.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16939/#review32007
-----------------------------------------------------------
Ship it!
Nice!
3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp
<https://reviews.apache.org/r/16939/#comment60754>
#include <stdlib.h>
- Jie Yu
On Jan. 16, 2014, 1:56 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16939/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 1:56 a.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, TILL TOENSHOFF, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary, this is used in libprocess to silence a warning from clang.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0725722ed99695ebe6d2410c4704d6f1b8d0ff7f
> 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16939/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 16939: Added UNREACHABLE to stout.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16939/#review32099
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp
<https://reviews.apache.org/r/16939/#comment60790>
#include <string>
- Ben Mahler
On Jan. 16, 2014, 1:56 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16939/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 1:56 a.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, TILL TOENSHOFF, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary, this is used in libprocess to silence a warning from clang.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 0725722ed99695ebe6d2410c4704d6f1b8d0ff7f
> 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16939/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>