You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Andrei Savu (JIRA)" <ji...@apache.org> on 2011/05/18 13:07:47 UTC
[jira] [Created] (WHIRR-311) Allow services to register new CLI
commands
Allow services to register new CLI commands
-------------------------------------------
Key: WHIRR-311
URL: https://issues.apache.org/jira/browse/WHIRR-311
Project: Whirr
Issue Type: Improvement
Components: cli, core
Reporter: Andrei Savu
Assignee: Andrei Savu
Fix For: 0.5.0
I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-311) Allow services to register new CLI
commands
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-311:
------------------------------
Resolution: Fixed
Fix Version/s: 0.6.0
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Tom for feedback.
> Allow services to register new CLI commands
> -------------------------------------------
>
> Key: WHIRR-311
> URL: https://issues.apache.org/jira/browse/WHIRR-311
> Project: Whirr
> Issue Type: Improvement
> Components: cli, core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.6.0
>
> Attachments: WHIRR-311.patch, WHIRR-311.patch
>
>
> I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-311) Allow services to register new CLI
commands
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-311:
------------------------------
Attachment: WHIRR-311.patch
Patch as described.
> Allow services to register new CLI commands
> -------------------------------------------
>
> Key: WHIRR-311
> URL: https://issues.apache.org/jira/browse/WHIRR-311
> Project: Whirr
> Issue Type: Improvement
> Components: cli, core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-311.patch
>
>
> I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-311) Allow services to register new CLI
commands
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042403#comment-13042403 ]
Andrei Savu commented on WHIRR-311:
-----------------------------------
Sounds good. I will update and commit the patch tomorrow.
> Allow services to register new CLI commands
> -------------------------------------------
>
> Key: WHIRR-311
> URL: https://issues.apache.org/jira/browse/WHIRR-311
> Project: Whirr
> Issue Type: Improvement
> Components: cli, core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Attachments: WHIRR-311.patch
>
>
> I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-311) Allow services to register new CLI
commands
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-311:
------------------------------
Fix Version/s: (was: 0.5.0)
> Allow services to register new CLI commands
> -------------------------------------------
>
> Key: WHIRR-311
> URL: https://issues.apache.org/jira/browse/WHIRR-311
> Project: Whirr
> Issue Type: Improvement
> Components: cli, core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Attachments: WHIRR-311.patch
>
>
> I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-311) Allow services to register new CLI
commands
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042179#comment-13042179 ]
Andrei Savu commented on WHIRR-311:
-----------------------------------
Good do commit or we need a way to separate them (visual separation on CLI output)?
> Allow services to register new CLI commands
> -------------------------------------------
>
> Key: WHIRR-311
> URL: https://issues.apache.org/jira/browse/WHIRR-311
> Project: Whirr
> Issue Type: Improvement
> Components: cli, core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Attachments: WHIRR-311.patch
>
>
> I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-311) Allow services to register new CLI
commands
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-311:
------------------------------
Attachment: WHIRR-311.patch
Updated patch as Tom suggested.
> Allow services to register new CLI commands
> -------------------------------------------
>
> Key: WHIRR-311
> URL: https://issues.apache.org/jira/browse/WHIRR-311
> Project: Whirr
> Issue Type: Improvement
> Components: cli, core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Attachments: WHIRR-311.patch, WHIRR-311.patch
>
>
> I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-311) Allow services to register new CLI
commands
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042303#comment-13042303 ]
Tom White commented on WHIRR-311:
---------------------------------
+1 This looks good. The only potential problem is that core and cli have overlapping packages (which may be a problem for OSGI?). How about changing the package in core to org.apache.whirr.command?
> Allow services to register new CLI commands
> -------------------------------------------
>
> Key: WHIRR-311
> URL: https://issues.apache.org/jira/browse/WHIRR-311
> Project: Whirr
> Issue Type: Improvement
> Components: cli, core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Attachments: WHIRR-311.patch
>
>
> I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-311) Allow services to register new CLI
commands
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-311:
------------------------------
Status: Patch Available (was: Open)
> Allow services to register new CLI commands
> -------------------------------------------
>
> Key: WHIRR-311
> URL: https://issues.apache.org/jira/browse/WHIRR-311
> Project: Whirr
> Issue Type: Improvement
> Components: cli, core
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-311.patch
>
>
> I believe it should be possible to define new CLI commands inside a service. I've changed the code to use Java SPI to discover the available commands. I had to move the following classes Command & AbastractClusterCommand from whirr-cli to whirr-core thanks to this maven "feature": http://jira.codehaus.org/browse/MNG-2758
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira