[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4699: check start time in range when deciding if needs notification

[GitBox <gi...@apache.org>]

xiaohui-sun opened a new pull request #4699: check start time in range when deciding if needs notification
URL: https://github.com/apache/incubator-pinot/pull/4699
 
 
   Currently we still see lots of notification tasks created with no anomaly to notify.
   The reason is in the vectorClock of the notification task it stores the end_time of the last notified anomaly.
   However the end_time may change due to merge. If merge happens then the last notified anomaly will have a newer end_time, and alert task scheduler thought it is a new anomaly.
   
   We can fix it by only check start_time.
   If there is new anomaly generated, then there should be anomaly with start_time larger than the  last notified anomaly's end_time (when notified).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org