[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26034: [SPARK-29364][SQL] Return an interval from date subtract according to SQL standard

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #26034: [SPARK-29364][SQL] Return an interval from date subtract according to SQL standard
URL: https://github.com/apache/spark/pull/26034#discussion_r331763210
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
 ##########
 @@ -836,7 +836,7 @@ class DateExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
     }
   }
 
-  test("datediff") {
+  test("datediff returns an integer") {
 
 Review comment:
   We had better have `withSQLConf(SQLConf.ANSI_ENABLED.key -> "true", SQLConf.DIALECT.key -> "...` here too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org