Re: Review Request 42856: Ambari not showing active/standby status for NameNodes when custom ports are used

[Eugene Chekanskiy <ec...@hortonworks.com>]

> On Jan. 29, 2016, 8:18 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java, line 566
> > <https://reviews.apache.org/r/42856/diff/1/?file=1224005#file1224005line566>
> >
> >     This only works for NameNode - what about other properties that follow this aliasing pattern, like YARN?

Fallback to old behaviour. Also for yarn rm ha we have other place when we getting this metrics, and it was already fixed.


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42856/#review117002
-----------------------------------------------------------


On Jan. 27, 2016, 4:13 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42856/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 4:13 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-14814
>     https://issues.apache.org/jira/browse/AMBARI-14814
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps:
> Deployed cluster via UI.
> Enabled NameNode HA.
> Enabled ResourceManager HA.
> Changed ports to custom (38088) for "yarn.resourcemanager.webapp.address.rm1" and "yarn.resourcemanager.webapp.address.rm2" properties.
> Restarted all services, required it.
> Enabled NameNodeHA.
> Changed ports to custom (38088) for
> dfs.namenode.http-address.nameservice.nn1
> dfs.namenode.http-address.nameservice.nn2
> dfs.namenode.https-address.nameservice.nn1
> dfs.namenode.https-address.nameservice.nn2
> dfs.namenode.rpc-address.nameservice.nn1
> dfs.namenode.rpc-address.nameservice.nn2 
> properties.
> Restarted all services, required it.
> Result: Ambari is not showing which NameNode is active and which one is standby.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 5fb2cf0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXHostProvider.java ca5b89f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java 2748dd4 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java 3ea5d7a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java f0c1280 
> 
> Diff: https://reviews.apache.org/r/42856/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>