Re: [PR] feat(go/adbc/driver/bigquery): Support BigQuery scopes [arrow-adbc]

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #3523:
URL: https://github.com/apache/arrow-adbc/pull/3523#discussion_r2405005348


##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -591,6 +602,11 @@ func (c *connectionImpl) newClient(ctx context.Context) error {
 		}
 	}
 
+	// Apply regular authentication scopes if specified (for non-impersonated auth)

Review Comment:
   Maybe it should error if both are set?



##########
go/adbc/driver/bigquery/driver_test.go:
##########
@@ -1589,3 +1589,231 @@ func TestAuthTypeConsolidation(t *testing.T) {
 		t.Errorf("Expected error message to contain 'unknown database auth type value', got: %v", err)
 	}
 }
+
+// ---- Auth Scopes Tests ----
+
+// TestAuthScopesSetGet tests setting and getting regular auth scopes
+func TestAuthScopesSetGet(t *testing.T) {
+	mem := memory.NewCheckedAllocator(memory.DefaultAllocator)
+	defer mem.AssertSize(t, 0)
+
+	drv := driver.NewDriver(mem)
+	db, err := drv.NewDatabase(nil)
+	if err != nil {
+		t.Fatalf("Failed to create database: %v", err)
+	}
+	defer func() {

Review Comment:
   Use `CheckedClose` for this instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org