You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@hotwaxsystems.com> on 2017/04/06 13:55:44 UTC

Re: svn commit: r1789159 - in /ofbiz/ofbiz-plugins/trunk/birt: entitydef/ entitydef/ServiceReportsView.xml ofbiz-component.xml

Jacques,

this commit broke the "view profile" screen of the Party Manager (and
possibly other screens):

partymgr/control/viewprofile?partyId=DemoCustomer

If you don't see the error then clear the cache and reload the page.

One problem is that the definition:

<alias entity-alias="PA" name="partyName"/>

is not valid (partyName is not a field of Party) but please check all the
other code you have committed here (or revert) because it requires more
extensive and thorough testing.

Jacopo


On Tue, Mar 28, 2017 at 5:08 PM, <jl...@apache.org> wrote:

> Author: jleroux
> Date: Tue Mar 28 15:08:24 2017
> New Revision: 1789159
>
> URL: http://svn.apache.org/viewvc?rev=1789159&view=rev
> Log:
> Fixed: Implement and demonstrate few services in Birt Report Builder
> (OFBIZ-9192)
>
> It was a long time I did not revisit this issue. I no longer stumbled upon
> issues I reported before in the Jira but found that 2 entities were
> missing.
>
> I was an easy fix: the ServiceReportsView.xml was missing
>
> Thanks: To Nicolas who in the meantime certainly committed fixes for the
> other
> issues I reported in the Jira
>
> Added:
>     ofbiz/ofbiz-plugins/trunk/birt/entitydef/
>     ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml
>  (with props)
> Modified:
>     ofbiz/ofbiz-plugins/trunk/birt/ofbiz-component.xml
>
> Added: ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
> birt/entitydef/ServiceReportsView.xml?rev=1789159&view=auto
> ============================================================
> ==================
> --- ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml
> (added)
> +++ ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml Tue
> Mar 28 15:08:24 2017
> @@ -0,0 +1,69 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!--
> +Licensed to the Apache Software Foundation (ASF) under one
> +or more contributor license agreements.  See the NOTICE file
> +distributed with this work for additional information
> +regarding copyright ownership.  The ASF licenses this file
> +to you under the Apache License, Version 2.0 (the
> +"License"); you may not use this file except in compliance
> +with the License.  You may obtain a copy of the License at
> +
> +http://www.apache.org/licenses/LICENSE-2.0
> +
> +Unless required by applicable law or agreed to in writing,
> +software distributed under the License is distributed on an
> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +KIND, either express or implied.  See the License for the
> +specific language governing permissions and limitations
> +under the License.
> +-->
> +
> +<entitymodel xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> +    xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/
> entitymodel.xsd">
> +    <title>View definitions for master report services</title>
> +    <description>None</description>
> +    <version>1.0</version>
> +
> +    <view-entity entity-name="OrderAndProductStore"
> package-name="org.ofbiz.birt">
> +        <member-entity entity-alias="OH" entity-name="OrderHeader"/>
> +        <member-entity entity-alias="PS" entity-name="ProductStore"/>
> +        <alias-all entity-alias="PS"/>
> +        <alias name="orderId" entity-alias="OH"/>
> +        <view-link entity-alias="OH" rel-entity-alias="PS">
> +            <key-map field-name="productStoreId"/>
> +        </view-link>
> +    </view-entity>
> +
> +    <view-entity entity-name="InvoiceItemProductAndParty"
> package-name="org.ofbiz.birt">
> +        <member-entity entity-alias="INV" entity-name="Invoice"/>
> +        <member-entity entity-alias="INITM" entity-name="InvoiceItem"/>
> +        <member-entity entity-alias="PA" entity-name="Party"/>
> +        <member-entity entity-alias="PRO" entity-name="Product"/>
> +        <alias entity-alias="INV" name="invoiceId"/>
> +        <alias entity-alias="INV" name="invoiceTypeId"/>
> +        <alias entity-alias="INV" name="invoicePartyId" field="partyId"/>
> +        <alias entity-alias="INV" name="statusId"/>
> +        <alias entity-alias="INV" name="invoiceDate"/>
> +        <alias entity-alias="INV" name="dueDate"/>
> +        <alias entity-alias="INV" name="currencyUomId"/>
> +<!--         <alias entity-alias="INITM" name="invoiceId"/> -->
> +        <alias entity-alias="INITM" name="invoiceItemSeqId"/>
> +        <alias entity-alias="INITM" name="invoiceItemTypeId"/>
> +        <alias entity-alias="INITM" name="quantity"/>
> +        <alias entity-alias="INITM" name="amount"/>
> +        <alias entity-alias="PA" name="partyId"/>
> +        <alias entity-alias="PA" name="partyName"/>
> +        <alias entity-alias="PRO" name="productId"/>
> +        <alias entity-alias="PRO" name="primaryProductCategoryId"/>
> +        <view-link entity-alias="INV" rel-entity-alias="INITM">
> +            <key-map field-name="invoiceId"/>
> +        </view-link>
> +        <view-link entity-alias="INV" rel-entity-alias="PA">
> +            <key-map field-name="partyId"/>
> +        </view-link>
> +        <view-link entity-alias="INITM" rel-entity-alias="PRO"
> rel-optional="true">
> +            <key-map field-name="productId"/>
> +        </view-link>
> +    </view-entity>
> +
> +</entitymodel>
> \ No newline at end of file
>
> Propchange: ofbiz/ofbiz-plugins/trunk/birt/entitydef/
> ServiceReportsView.xml
> ------------------------------------------------------------
> ------------------
>     svn:eol-style = native
>
> Propchange: ofbiz/ofbiz-plugins/trunk/birt/entitydef/
> ServiceReportsView.xml
> ------------------------------------------------------------
> ------------------
>     svn:keywords = Date Rev Author URL Id
>
> Propchange: ofbiz/ofbiz-plugins/trunk/birt/entitydef/
> ServiceReportsView.xml
> ------------------------------------------------------------
> ------------------
>     svn:mime-type = text/xml
>
> Modified: ofbiz/ofbiz-plugins/trunk/birt/ofbiz-component.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
> birt/ofbiz-component.xml?rev=1789159&r1=1789158&r2=1789159&view=diff
> ============================================================
> ==================
> --- ofbiz/ofbiz-plugins/trunk/birt/ofbiz-component.xml (original)
> +++ ofbiz/ofbiz-plugins/trunk/birt/ofbiz-component.xml Tue Mar 28
> 15:08:24 2017
> @@ -30,6 +30,8 @@ under the License.
>      <entity-resource type="data" reader-name="demo" loader="main"
> location="data/BirtSecurityGroupDemoData.xml"/>
>      <entity-resource type="data" reader-name="demo" loader="main"
> location="data/BirtMasterData.xml"/>
>
> +    <entity-resource type="model" reader-name="main" loader="main"
> location="entitydef/ServiceReportsView.xml"/>
> +
>      <service-resource type="model" loader="main"
> location="servicedef/services.xml"/>
>
>      <webapp name="accounting"
>
>
>

Re: svn commit: r1789159 - in /ofbiz/ofbiz-plugins/trunk/birt: entitydef/ entitydef/ServiceReportsView.xml ofbiz-component.xml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Jacopo,

I'll review it again

Jacques


Le 06/04/2017 � 15:55, Jacopo Cappellato a �crit :
> Jacques,
>
> this commit broke the "view profile" screen of the Party Manager (and
> possibly other screens):
>
> partymgr/control/viewprofile?partyId=DemoCustomer
>
> If you don't see the error then clear the cache and reload the page.
>
> One problem is that the definition:
>
> <alias entity-alias="PA" name="partyName"/>
>
> is not valid (partyName is not a field of Party) but please check all the
> other code you have committed here (or revert) because it requires more
> extensive and thorough testing.
>
> Jacopo
>
>
> On Tue, Mar 28, 2017 at 5:08 PM, <jl...@apache.org> wrote:
>
>> Author: jleroux
>> Date: Tue Mar 28 15:08:24 2017
>> New Revision: 1789159
>>
>> URL: http://svn.apache.org/viewvc?rev=1789159&view=rev
>> Log:
>> Fixed: Implement and demonstrate few services in Birt Report Builder
>> (OFBIZ-9192)
>>
>> It was a long time I did not revisit this issue. I no longer stumbled upon
>> issues I reported before in the Jira but found that 2 entities were
>> missing.
>>
>> I was an easy fix: the ServiceReportsView.xml was missing
>>
>> Thanks: To Nicolas who in the meantime certainly committed fixes for the
>> other
>> issues I reported in the Jira
>>
>> Added:
>>      ofbiz/ofbiz-plugins/trunk/birt/entitydef/
>>      ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml
>>   (with props)
>> Modified:
>>      ofbiz/ofbiz-plugins/trunk/birt/ofbiz-component.xml
>>
>> Added: ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
>> birt/entitydef/ServiceReportsView.xml?rev=1789159&view=auto
>> ============================================================
>> ==================
>> --- ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml
>> (added)
>> +++ ofbiz/ofbiz-plugins/trunk/birt/entitydef/ServiceReportsView.xml Tue
>> Mar 28 15:08:24 2017
>> @@ -0,0 +1,69 @@
>> +<?xml version="1.0" encoding="UTF-8"?>
>> +<!--
>> +Licensed to the Apache Software Foundation (ASF) under one
>> +or more contributor license agreements.  See the NOTICE file
>> +distributed with this work for additional information
>> +regarding copyright ownership.  The ASF licenses this file
>> +to you under the Apache License, Version 2.0 (the
>> +"License"); you may not use this file except in compliance
>> +with the License.  You may obtain a copy of the License at
>> +
>> +http://www.apache.org/licenses/LICENSE-2.0
>> +
>> +Unless required by applicable law or agreed to in writing,
>> +software distributed under the License is distributed on an
>> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>> +KIND, either express or implied.  See the License for the
>> +specific language governing permissions and limitations
>> +under the License.
>> +-->
>> +
>> +<entitymodel xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>> +    xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/
>> entitymodel.xsd">
>> +    <title>View definitions for master report services</title>
>> +    <description>None</description>
>> +    <version>1.0</version>
>> +
>> +    <view-entity entity-name="OrderAndProductStore"
>> package-name="org.ofbiz.birt">
>> +        <member-entity entity-alias="OH" entity-name="OrderHeader"/>
>> +        <member-entity entity-alias="PS" entity-name="ProductStore"/>
>> +        <alias-all entity-alias="PS"/>
>> +        <alias name="orderId" entity-alias="OH"/>
>> +        <view-link entity-alias="OH" rel-entity-alias="PS">
>> +            <key-map field-name="productStoreId"/>
>> +        </view-link>
>> +    </view-entity>
>> +
>> +    <view-entity entity-name="InvoiceItemProductAndParty"
>> package-name="org.ofbiz.birt">
>> +        <member-entity entity-alias="INV" entity-name="Invoice"/>
>> +        <member-entity entity-alias="INITM" entity-name="InvoiceItem"/>
>> +        <member-entity entity-alias="PA" entity-name="Party"/>
>> +        <member-entity entity-alias="PRO" entity-name="Product"/>
>> +        <alias entity-alias="INV" name="invoiceId"/>
>> +        <alias entity-alias="INV" name="invoiceTypeId"/>
>> +        <alias entity-alias="INV" name="invoicePartyId" field="partyId"/>
>> +        <alias entity-alias="INV" name="statusId"/>
>> +        <alias entity-alias="INV" name="invoiceDate"/>
>> +        <alias entity-alias="INV" name="dueDate"/>
>> +        <alias entity-alias="INV" name="currencyUomId"/>
>> +<!--         <alias entity-alias="INITM" name="invoiceId"/> -->
>> +        <alias entity-alias="INITM" name="invoiceItemSeqId"/>
>> +        <alias entity-alias="INITM" name="invoiceItemTypeId"/>
>> +        <alias entity-alias="INITM" name="quantity"/>
>> +        <alias entity-alias="INITM" name="amount"/>
>> +        <alias entity-alias="PA" name="partyId"/>
>> +        <alias entity-alias="PA" name="partyName"/>
>> +        <alias entity-alias="PRO" name="productId"/>
>> +        <alias entity-alias="PRO" name="primaryProductCategoryId"/>
>> +        <view-link entity-alias="INV" rel-entity-alias="INITM">
>> +            <key-map field-name="invoiceId"/>
>> +        </view-link>
>> +        <view-link entity-alias="INV" rel-entity-alias="PA">
>> +            <key-map field-name="partyId"/>
>> +        </view-link>
>> +        <view-link entity-alias="INITM" rel-entity-alias="PRO"
>> rel-optional="true">
>> +            <key-map field-name="productId"/>
>> +        </view-link>
>> +    </view-entity>
>> +
>> +</entitymodel>
>> \ No newline at end of file
>>
>> Propchange: ofbiz/ofbiz-plugins/trunk/birt/entitydef/
>> ServiceReportsView.xml
>> ------------------------------------------------------------
>> ------------------
>>      svn:eol-style = native
>>
>> Propchange: ofbiz/ofbiz-plugins/trunk/birt/entitydef/
>> ServiceReportsView.xml
>> ------------------------------------------------------------
>> ------------------
>>      svn:keywords = Date Rev Author URL Id
>>
>> Propchange: ofbiz/ofbiz-plugins/trunk/birt/entitydef/
>> ServiceReportsView.xml
>> ------------------------------------------------------------
>> ------------------
>>      svn:mime-type = text/xml
>>
>> Modified: ofbiz/ofbiz-plugins/trunk/birt/ofbiz-component.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/
>> birt/ofbiz-component.xml?rev=1789159&r1=1789158&r2=1789159&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/ofbiz-plugins/trunk/birt/ofbiz-component.xml (original)
>> +++ ofbiz/ofbiz-plugins/trunk/birt/ofbiz-component.xml Tue Mar 28
>> 15:08:24 2017
>> @@ -30,6 +30,8 @@ under the License.
>>       <entity-resource type="data" reader-name="demo" loader="main"
>> location="data/BirtSecurityGroupDemoData.xml"/>
>>       <entity-resource type="data" reader-name="demo" loader="main"
>> location="data/BirtMasterData.xml"/>
>>
>> +    <entity-resource type="model" reader-name="main" loader="main"
>> location="entitydef/ServiceReportsView.xml"/>
>> +
>>       <service-resource type="model" loader="main"
>> location="servicedef/services.xml"/>
>>
>>       <webapp name="accounting"
>>
>>
>>