You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/17 14:18:30 UTC

[GitHub] [arrow] pitrou commented on pull request #9739: ARROW-12000: [Documentation] Add note about deviation from style guide on struct/classes

pitrou commented on pull request #9739:
URL: https://github.com/apache/arrow/pull/9739#issuecomment-801118593


   This doesn't seem exact. We have `struct` types in public headers (such as `filesystem.h`).
   I think @wesm 's rationale seems more faithful to reality:
   > In the public headers we should be trying to use struct only for objects that are principally simple data containers where we are OK with exposing all the internal members, and any methods are primarily conveniences.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org