You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/13 05:51:47 UTC
[GitHub] [dolphinscheduler] liqingwang opened a new issue, #10425: [Improvement][LDAP] LDAP bug fix && Improvements
liqingwang opened a new issue, #10425:
URL: https://github.com/apache/dolphinscheduler/issues/10425
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Recently, We have tried to enable LDAP on DS and found some questions.
- 1. version 2.0.5 User disabled and can't log in, and `dev` has the same bug, see #10386
- 2. Due to the above question, we need to add a unit test to cover the LDAP user login case.
- 3. When you log in with LDAP and are not a ds user, it will create a new user automatedly. But in my option, LDAP login is the same as user-password log-in, if you are not a ds user, your login will be rejected. I think we can add a new config field, user can choose if they log in with LDAP and are not a ds user, which will create a new user or be rejected.
- 4. ds config `security.authentication.type` only can be `password` or `LDAP` log in. And do we need the mixed login same as Jenkins or Rancher?
- 5. When you log in with LDAP. And there are still change password pages. But LDAP users have no password config. I think hiding this page when you log in with LDAP is better.
- 6. dev branch has no LDAP config in the YAML file. Due to https://github.com/apache/dolphinscheduler/commit/4114cb07f64950f88ffb4aa8a4ecc4815f32d76b#diff-f2f54230647b5ed6920efc032cd61c4dc2acd8f728ad0f43aef1e8fd3f9793ed , I'll fix this and make LDAP to a switch,not a comments config.
- 7. And some contributor says LDAP needs some improvements, I'll fix this. See #10274
- 8. The last one, LDAP miss document, And I'll fix this too. See #10250
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #10425: [Improvement][LDAP] LDAP bug fix && Improvements
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #10425:
URL: https://github.com/apache/dolphinscheduler/issues/10425#issuecomment-1161480471
> * [[Bug] [LDAP] DS LDAP authenticator needs improvements #10274](https://github.com/apache/dolphinscheduler/issues/10274) Will be fixed by @EricGao888 Thx
Sure, I will finish the remaining work. Thx @liqingwang for the contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on issue #10425: [Improvement][LDAP] LDAP bug fix && Improvements
Posted by GitBox <gi...@apache.org>.
liqingwang commented on issue #10425:
URL: https://github.com/apache/dolphinscheduler/issues/10425#issuecomment-1161467582
- #10274 Will be fixed by @EricGao888 Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #10425: [Improvement][LDAP] LDAP bug fix && Improvements
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #10425:
URL: https://github.com/apache/dolphinscheduler/issues/10425#issuecomment-1153503935
It seem that @EricGao888 is also working on some LDAP feature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10425: [Improvement][LDAP] LDAP bug fix && Improvements
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10425:
URL: https://github.com/apache/dolphinscheduler/issues/10425#issuecomment-1153500605
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed informationăversion or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on issue #10425: [Improvement][LDAP] LDAP bug fix && Improvements
Posted by GitBox <gi...@apache.org>.
liqingwang commented on issue #10425:
URL: https://github.com/apache/dolphinscheduler/issues/10425#issuecomment-1153511266
@EricGao888 Sure, Thanks for your reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on issue #10425: [Improvement][LDAP] LDAP bug fix && Improvements
Posted by GitBox <gi...@apache.org>.
liqingwang commented on issue #10425:
URL: https://github.com/apache/dolphinscheduler/issues/10425#issuecomment-1153505883
Yes, I already talk to @EricGao888 and we make a deal and I'll handle with LDAP part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #10425: [Improvement][LDAP] LDAP bug fix && Improvements
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #10425:
URL: https://github.com/apache/dolphinscheduler/issues/10425#issuecomment-1153507970
> It seem that @EricGao888 is also working on some LDAP feature
@liqingwang Looks cool to me. Just a kind reminder, there could be some differences between `Microsoft AD` and `a typical OpenLDAP`. Both of them are supposed to be taken into consideration, as described here: https://github.com/apache/dolphinscheduler/issues/10274#issuecomment-1140431540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org