You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/08/11 11:48:52 UTC

[PR] fix(metrics): validate Prometheus value types [rocketmq-dashboard]

123123213weqw opened a new pull request, #1742:
URL: https://github.com/apache/rocketmq-dashboard/pull/1742

   ## Summary
   - reject non-text Prometheus sample values instead of coercing them
   - reject structured/null label values instead of silently converting them
   - reject non-finite sample and histogram timestamps
   
   ## Testing
   - `mvn -q -Dtest=PrometheusMetricsSourceTest test`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(metrics): validate Prometheus value types [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1742:
URL: https://github.com/apache/rocketmq-dashboard/pull/1742#issuecomment-5277814815

   Consolidated into #1114 as part of the batch consolidation of @123123213weqw's open PRs (merged into the rocketmq-studio branch), so closing this one. The change is preserved in the merged commit; please direct any follow-ups there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(metrics): validate Prometheus value types [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1742: fix(metrics): validate Prometheus value types
URL: https://github.com/apache/rocketmq-dashboard/pull/1742


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org