You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by windpiger <gi...@git.apache.org> on 2017/03/18 12:24:52 UTC
[GitHub] spark pull request #17340: [SPARK-20013][SQL] merge renameTable to alterTabl...
GitHub user windpiger opened a pull request:
https://github.com/apache/spark/pull/17340
[SPARK-20013][SQL] merge renameTable to alterTable in ExternCatalog
## What changes were proposed in this pull request?
## How was this patch tested?
delete some tests in ExternalCatalogSuite which already existed in SessionCatalogSuite,
and move some other tests in ExternalCatalogSuite which does not exist in SessionCatalogSuite
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/windpiger/spark renameTable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17340
----
commit 70f2365bec31fa3c3a53eebe73991871cdd77e56
Author: windpiger <so...@outlook.com>
Date: 2017-03-09T08:03:19Z
use alterTable to implement renameTabe
commit e8b9ea36c586ce1af63ee7eb3dbc052455cfcdd0
Author: windpiger <so...@outlook.com>
Date: 2017-03-18T10:17:33Z
Merge branch 'master' into renameTable
commit 26c6c7b05d1c7020cbc59784ce7ea4864c9c2b2b
Author: windpiger <so...@outlook.com>
Date: 2017-03-18T11:53:58Z
merge with master and move some tests to SessionCatalogSuite
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17340
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17340
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17340
**[Test build #74780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74780/testReport)** for PR 17340 at commit [`bea0956`](https://github.com/apache/spark/commit/bea0956ed0243a43c450e55d939792d633d9ee2b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17340
**[Test build #74778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74778/testReport)** for PR 17340 at commit [`8d287d3`](https://github.com/apache/spark/commit/8d287d33b98ed1f1acd7aa81dfa0d78a6c403b9a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL][WIP] merge renameTable to alterTable ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17340
**[Test build #74780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74780/testReport)** for PR 17340 at commit [`bea0956`](https://github.com/apache/spark/commit/bea0956ed0243a43c450e55d939792d633d9ee2b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL][WIP] merge renameTable to alterTable ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17340
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74780/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17340
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74778/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17340
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74779/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17340
**[Test build #74777 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74777/testReport)** for PR 17340 at commit [`26c6c7b`](https://github.com/apache/spark/commit/26c6c7b05d1c7020cbc59784ce7ea4864c9c2b2b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17340
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17340
**[Test build #74779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74779/testReport)** for PR 17340 at commit [`7c8d92b`](https://github.com/apache/spark/commit/7c8d92b3a497f006c6533e575a18b62113c448d6).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17340: [SPARK-20013][SQL] merge renameTable to alterTabl...
Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780097
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala ---
@@ -196,50 +196,6 @@ abstract class ExternalCatalogSuite extends SparkFunSuite with BeforeAndAfterEac
catalog.dropTable("db2", "unknown_table", ignoreIfNotExists = true, purge = false)
}
- test("rename table") {
- val catalog = newBasicCatalog()
- assert(catalog.listTables("db2").toSet == Set("tbl1", "tbl2"))
- catalog.renameTable("db2", "tbl1", "tblone")
- assert(catalog.listTables("db2").toSet == Set("tblone", "tbl2"))
- }
-
- test("rename table when database/table does not exist") {
--- End diff --
already existed in [SessionCatalog](https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala#L393)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17340
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74777/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17340: [SPARK-20013][SQL][WIP] merge renameTable to alte...
Posted by windpiger <gi...@git.apache.org>.
Github user windpiger closed the pull request at:
https://github.com/apache/spark/pull/17340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL][WIP] merge renameTable to alterTable ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17340
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17340: [SPARK-20013][SQL] merge renameTable to alterTabl...
Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780090
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala ---
@@ -196,50 +196,6 @@ abstract class ExternalCatalogSuite extends SparkFunSuite with BeforeAndAfterEac
catalog.dropTable("db2", "unknown_table", ignoreIfNotExists = true, purge = false)
}
- test("rename table") {
--- End diff --
already existed in [SessionCatalog](https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala#L361)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17340
**[Test build #74777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74777/testReport)** for PR 17340 at commit [`26c6c7b`](https://github.com/apache/spark/commit/26c6c7b05d1c7020cbc59784ce7ea4864c9c2b2b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17340: [SPARK-20013][SQL] merge renameTable to alterTabl...
Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780030
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala ---
@@ -196,50 +196,6 @@ abstract class ExternalCatalogSuite extends SparkFunSuite with BeforeAndAfterEac
catalog.dropTable("db2", "unknown_table", ignoreIfNotExists = true, purge = false)
}
- test("rename table") {
- val catalog = newBasicCatalog()
- assert(catalog.listTables("db2").toSet == Set("tbl1", "tbl2"))
- catalog.renameTable("db2", "tbl1", "tblone")
- assert(catalog.listTables("db2").toSet == Set("tblone", "tbl2"))
- }
-
- test("rename table when database/table does not exist") {
- val catalog = newBasicCatalog()
- intercept[AnalysisException] {
- catalog.renameTable("unknown_db", "unknown_table", "unknown_table")
- }
- intercept[AnalysisException] {
- catalog.renameTable("db2", "unknown_table", "unknown_table")
- }
- }
-
- test("rename table when destination table already exists") {
- val catalog = newBasicCatalog()
- intercept[AnalysisException] {
- catalog.renameTable("db2", "tbl1", "tbl2")
- }
- }
-
- test("alter table") {
--- End diff --
already existed in SessionCatalog
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17340
**[Test build #74779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74779/testReport)** for PR 17340 at commit [`7c8d92b`](https://github.com/apache/spark/commit/7c8d92b3a497f006c6533e575a18b62113c448d6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17340: [SPARK-20013][SQL] merge renameTable to alterTable in Ex...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17340
**[Test build #74778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74778/testReport)** for PR 17340 at commit [`8d287d3`](https://github.com/apache/spark/commit/8d287d33b98ed1f1acd7aa81dfa0d78a6c403b9a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17340: [SPARK-20013][SQL] merge renameTable to alterTabl...
Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780033
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala ---
@@ -196,50 +196,6 @@ abstract class ExternalCatalogSuite extends SparkFunSuite with BeforeAndAfterEac
catalog.dropTable("db2", "unknown_table", ignoreIfNotExists = true, purge = false)
}
- test("rename table") {
- val catalog = newBasicCatalog()
- assert(catalog.listTables("db2").toSet == Set("tbl1", "tbl2"))
- catalog.renameTable("db2", "tbl1", "tblone")
- assert(catalog.listTables("db2").toSet == Set("tblone", "tbl2"))
- }
-
- test("rename table when database/table does not exist") {
- val catalog = newBasicCatalog()
- intercept[AnalysisException] {
- catalog.renameTable("unknown_db", "unknown_table", "unknown_table")
- }
- intercept[AnalysisException] {
- catalog.renameTable("db2", "unknown_table", "unknown_table")
- }
- }
-
- test("rename table when destination table already exists") {
- val catalog = newBasicCatalog()
- intercept[AnalysisException] {
- catalog.renameTable("db2", "tbl1", "tbl2")
- }
- }
-
- test("alter table") {
- val catalog = newBasicCatalog()
- val tbl1 = catalog.getTable("db2", "tbl1")
- catalog.alterTable(tbl1.copy(properties = Map("toh" -> "frem")))
- val newTbl1 = catalog.getTable("db2", "tbl1")
- assert(!tbl1.properties.contains("toh"))
- assert(newTbl1.properties.size == tbl1.properties.size + 1)
- assert(newTbl1.properties.get("toh") == Some("frem"))
- }
-
- test("alter table when database/table does not exist") {
--- End diff --
already existed in SessionCatalog
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17340: [SPARK-20013][SQL] merge renameTable to alterTabl...
Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780117
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala ---
@@ -732,40 +676,6 @@ abstract class ExternalCatalogSuite extends SparkFunSuite with BeforeAndAfterEac
assert(!exists(db.locationUri))
}
- test("create/drop/rename table should create/delete/rename the directory") {
--- End diff --
move to `SessionCatalogSuite`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17340: [SPARK-20013][SQL] merge renameTable to alterTabl...
Posted by windpiger <gi...@git.apache.org>.
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17340#discussion_r106780038
--- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala ---
@@ -196,50 +196,6 @@ abstract class ExternalCatalogSuite extends SparkFunSuite with BeforeAndAfterEac
catalog.dropTable("db2", "unknown_table", ignoreIfNotExists = true, purge = false)
}
- test("rename table") {
- val catalog = newBasicCatalog()
- assert(catalog.listTables("db2").toSet == Set("tbl1", "tbl2"))
- catalog.renameTable("db2", "tbl1", "tblone")
- assert(catalog.listTables("db2").toSet == Set("tblone", "tbl2"))
- }
-
- test("rename table when database/table does not exist") {
- val catalog = newBasicCatalog()
- intercept[AnalysisException] {
- catalog.renameTable("unknown_db", "unknown_table", "unknown_table")
- }
- intercept[AnalysisException] {
- catalog.renameTable("db2", "unknown_table", "unknown_table")
- }
- }
-
- test("rename table when destination table already exists") {
--- End diff --
move to `SessionCatalog`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org