You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/09/13 21:50:03 UTC

[GitHub] [netbeans] junichi11 commented on a change in pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon

junichi11 commented on a change in pull request #1501: [NETBEANS-3041] Support passing JVM Arguments to Gradle Daemon
URL: https://github.com/apache/netbeans/pull/1501#discussion_r324379851
 
 

 ##########
 File path: groovy/gradle/src/org/netbeans/modules/gradle/api/execute/GradleCommandLine.java
 ##########
 @@ -802,13 +810,71 @@ public void setStackTrace(StackTrace st) {
         }
     }
 
-    public void configure(ConfigurableLauncher launcher) {
-        launcher.setJvmArguments(getArgs(EnumSet.of(SYSTEM)));
+    private void addGradleSettingJvmargs(File projectDir, List<String> jvmargs) {
+        List<File> gpfs = null; 
 
 Review comment:
   The variable name is not easy to understand...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists