You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/18 10:16:00 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #3137: fix a
daily test fail
yangzhg opened a new pull request #3137: fix a daily test fail
URL: https://github.com/apache/incubator-doris/pull/3137
fix a bug of const union query like `select null union select null`, this because the type of SlotDescriptor when claus is `select null ` is null ,this will cause be core dump, and fe find wrong cast function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3137: fix a daily test fail
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3137: fix a daily test fail
URL: https://github.com/apache/incubator-doris/pull/3137#discussion_r394307240
##########
File path: fe/src/main/java/org/apache/doris/analysis/CastExpr.java
##########
@@ -105,10 +105,10 @@ public static void initBuiltins(FunctionSet functionSet) {
}
// Disable casting from boolean to decimal
Review comment:
Change the comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3137: fix a daily test fail
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3137: fix a daily test fail
URL: https://github.com/apache/incubator-doris/pull/3137#discussion_r394307895
##########
File path: fe/src/main/java/org/apache/doris/analysis/SetOperationStmt.java
##########
@@ -649,7 +649,8 @@ public void analyze(Analyzer parent) throws AnalysisException, UserException {
if (isAnalyzed()) {
return;
}
- if (queryStmt instanceof SelectStmt && ((SelectStmt) queryStmt).fromClause_.isEmpty()) {
+ if (operation != Operation.UNION && queryStmt instanceof SelectStmt
Review comment:
Could you add comment to explain why you change here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3137: fix a daily
test fail
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3137: fix a daily test fail
URL: https://github.com/apache/incubator-doris/pull/3137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org