You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/11 06:16:08 UTC
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #27861:
[SPARK-30707][SQL]Window function set partitionSpec as order spec when
orderSpec is empty
AngersZhuuuu commented on a change in pull request #27861: [SPARK-30707][SQL]Window function set partitionSpec as order spec when orderSpec is empty
URL: https://github.com/apache/spark/pull/27861#discussion_r390763768
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part3.sql.out
##########
@@ -243,9 +243,8 @@ from t1 where f1 = f2
-- !query schema
struct<>
-- !query output
-org.apache.spark.sql.AnalysisException
-cannot resolve '(PARTITION BY spark_catalog.default.t1.`f1` RANGE BETWEEN 1 PRECEDING AND 1 FOLLOWING)' due to data type mismatch: A range window frame cannot be used in an unordered window specification.; line 1 pos 24
Review comment:
> is there any result changing after this PR?
Yeah, will add order spec then won't meet this problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org