You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2014/08/14 21:03:30 UTC
svn commit: r1618017 -
/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/JdbcDatabaseManager.java
Author: mattsicker
Date: Thu Aug 14 19:03:30 2014
New Revision: 1618017
URL: http://svn.apache.org/r1618017
Log:
Revert lazy singleton.
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/JdbcDatabaseManager.java
Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/JdbcDatabaseManager.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/JdbcDatabaseManager.java?rev=1618017&r1=1618016&r2=1618017&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/JdbcDatabaseManager.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/db/jdbc/JdbcDatabaseManager.java Thu Aug 14 19:03:30 2014
@@ -37,6 +37,8 @@ import org.apache.logging.log4j.core.uti
*/
public final class JdbcDatabaseManager extends AbstractDatabaseManager {
+ private static final JDBCDatabaseManagerFactory INSTANCE = new JDBCDatabaseManagerFactory();
+
private final List<Column> columns;
private final ConnectionSource connectionSource;
private final String sqlStatement;
@@ -177,13 +179,8 @@ public final class JdbcDatabaseManager e
);
}
- // the usual lazy singleton
- private static class Holder {
- private static final JDBCDatabaseManagerFactory INSTANCE = new JDBCDatabaseManagerFactory();
- }
-
private static JDBCDatabaseManagerFactory getFactory() {
- return Holder.INSTANCE;
+ return INSTANCE;
}
/**