You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/01/29 19:00:18 UTC

Review Request 17503: Application Views Infrastructure and allowing new views and API extensibility - framework

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17503/
-----------------------------------------------------------

Review request for Ambari, Mahadev Konar, Nate Cole, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-4461
    https://issues.apache.org/jira/browse/AMBARI-4461


Repository: ambari


Description
-------

Add code to enable the deployment of a View in Ambari.

This is the 3rd Ambari View checkin after the interfaces and configuration.  This patch should make is possible to deploy Views into Ambari.  

The changes include ...

1) the API framework changes needed to add Views and ViewInstance resource types to the Ambari REST API
2) the View framework needed to deploy and access views 
3) unit tests for the new view framework

Some View features not addressed in this patch ...

1) persistent view instances in Ambari DB
2) view security
3) more flexible view UI features
4) view access to Ambari DB
5) default resource provider to persist View resource to Ambari DB


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java de6307c 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java b070d98 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 00f1b74 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java a10835e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a82e59 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ClusterControllerHelper.java 3b0c12a 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewProviderModule.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 87f9a96 

Diff: https://reviews.apache.org/r/17503/diff/


Testing
-------

Added new unit tests for view classes.

All ambari-server unit tests pass :

Results :

Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7


Thanks,

Tom Beerbower

Re: Review Request 17503: Application Views Infrastructure and allowing new views and API extensibility - framework

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17503/#review33145
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Jan. 29, 2014, 6:46 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17503/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 6:46 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-4461
>     https://issues.apache.org/jira/browse/AMBARI-4461
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add code to enable the deployment of a View in Ambari.
> 
> This is the 3rd Ambari View checkin after the interfaces and configuration.  This patch should make is possible to deploy Views into Ambari.  
> 
> The changes include ...
> 
> 1) the API framework changes needed to add Views and ViewInstance resource types to the Ambari REST API
> 2) the View framework needed to deploy and access views 
> 3) unit tests for the new view framework
> 
> Some View features not addressed in this patch ...
> 
> 1) persistent view instances in Ambari DB
> 2) view security
> 3) more flexible view UI features
> 4) view access to Ambari DB
> 5) default resource provider to persist View resource to Ambari DB
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java de6307c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java b070d98 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 00f1b74 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java a10835e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a82e59 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ClusterControllerHelper.java 3b0c12a 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewProviderModule.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 87f9a96 
> 
> Diff: https://reviews.apache.org/r/17503/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests for view classes.
> 
> All ambari-server unit tests pass :
> 
> Results :
> 
> Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 17503: Application Views Infrastructure and allowing new views and API extensibility - framework

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17503/#review33141
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Jan. 29, 2014, 1:46 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17503/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 1:46 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-4461
>     https://issues.apache.org/jira/browse/AMBARI-4461
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add code to enable the deployment of a View in Ambari.
> 
> This is the 3rd Ambari View checkin after the interfaces and configuration.  This patch should make is possible to deploy Views into Ambari.  
> 
> The changes include ...
> 
> 1) the API framework changes needed to add Views and ViewInstance resource types to the Ambari REST API
> 2) the View framework needed to deploy and access views 
> 3) unit tests for the new view framework
> 
> Some View features not addressed in this patch ...
> 
> 1) persistent view instances in Ambari DB
> 2) view security
> 3) more flexible view UI features
> 4) view access to Ambari DB
> 5) default resource provider to persist View resource to Ambari DB
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java de6307c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java b070d98 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 00f1b74 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java a10835e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a82e59 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ClusterControllerHelper.java 3b0c12a 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewProviderModule.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 87f9a96 
> 
> Diff: https://reviews.apache.org/r/17503/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests for view classes.
> 
> All ambari-server unit tests pass :
> 
> Results :
> 
> Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 17503: Application Views Infrastructure and allowing new views and API extensibility - framework

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17503/
-----------------------------------------------------------

(Updated Jan. 29, 2014, 6:46 p.m.)


Review request for Ambari, Mahadev Konar, Nate Cole, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-4461
    https://issues.apache.org/jira/browse/AMBARI-4461


Repository: ambari


Description
-------

Add code to enable the deployment of a View in Ambari.

This is the 3rd Ambari View checkin after the interfaces and configuration.  This patch should make is possible to deploy Views into Ambari.  

The changes include ...

1) the API framework changes needed to add Views and ViewInstance resource types to the Ambari REST API
2) the View framework needed to deploy and access views 
3) unit tests for the new view framework

Some View features not addressed in this patch ...

1) persistent view instances in Ambari DB
2) view security
3) more flexible view UI features
4) view access to Ambari DB
5) default resource provider to persist View resource to Ambari DB


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java de6307c 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java b070d98 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 00f1b74 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java a10835e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a82e59 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ClusterControllerHelper.java 3b0c12a 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewProviderModule.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewResourceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 87f9a96 

Diff: https://reviews.apache.org/r/17503/diff/


Testing
-------

Added new unit tests for view classes.

All ambari-server unit tests pass :

Results :

Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7


Thanks,

Tom Beerbower

Re: Review Request 17503: Application Views Infrastructure and allowing new views and API extensibility - framework

Posted by Tom Beerbower <tb...@hortonworks.com>.

> On Jan. 29, 2014, 6:20 p.m., Nate Cole wrote:
> > In AmbariServer, this line:
> > 
> > ViewRegistry.readViewArchives(configs, root, springSecurityFilter);
> > 
> > will fail to load the entire server when there is an error with a view file.  It may be prudent to either try/catch each discovered view file, or try/catch all of them so as to not fail.  Not sure if it's necessary, but something to consider.

Good point Nate.  Probably best to try/catch each one.  I'll update the patch.  Thanks!


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17503/#review33130
-----------------------------------------------------------


On Jan. 29, 2014, 6 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17503/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 6 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-4461
>     https://issues.apache.org/jira/browse/AMBARI-4461
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add code to enable the deployment of a View in Ambari.
> 
> This is the 3rd Ambari View checkin after the interfaces and configuration.  This patch should make is possible to deploy Views into Ambari.  
> 
> The changes include ...
> 
> 1) the API framework changes needed to add Views and ViewInstance resource types to the Ambari REST API
> 2) the View framework needed to deploy and access views 
> 3) unit tests for the new view framework
> 
> Some View features not addressed in this patch ...
> 
> 1) persistent view instances in Ambari DB
> 2) view security
> 3) more flexible view UI features
> 4) view access to Ambari DB
> 5) default resource provider to persist View resource to Ambari DB
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java de6307c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java b070d98 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 00f1b74 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java a10835e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a82e59 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ClusterControllerHelper.java 3b0c12a 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewProviderModule.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 87f9a96 
> 
> Diff: https://reviews.apache.org/r/17503/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests for view classes.
> 
> All ambari-server unit tests pass :
> 
> Results :
> 
> Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 17503: Application Views Infrastructure and allowing new views and API extensibility - framework

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17503/#review33130
-----------------------------------------------------------


In AmbariServer, this line:

ViewRegistry.readViewArchives(configs, root, springSecurityFilter);

will fail to load the entire server when there is an error with a view file.  It may be prudent to either try/catch each discovered view file, or try/catch all of them so as to not fail.  Not sure if it's necessary, but something to consider.

- Nate Cole


On Jan. 29, 2014, 1 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17503/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 1 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-4461
>     https://issues.apache.org/jira/browse/AMBARI-4461
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add code to enable the deployment of a View in Ambari.
> 
> This is the 3rd Ambari View checkin after the interfaces and configuration.  This patch should make is possible to deploy Views into Ambari.  
> 
> The changes include ...
> 
> 1) the API framework changes needed to add Views and ViewInstance resource types to the Ambari REST API
> 2) the View framework needed to deploy and access views 
> 3) unit tests for the new view framework
> 
> Some View features not addressed in this patch ...
> 
> 1) persistent view instances in Ambari DB
> 2) view security
> 3) more flexible view UI features
> 4) view access to Ambari DB
> 5) default resource provider to persist View resource to Ambari DB
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java de6307c 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ViewResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewSubResourceService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java b070d98 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 00f1b74 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java a10835e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 6a82e59 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ClusterControllerHelper.java 3b0c12a 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewProviderModule.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewInstanceResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/ViewResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewSubResourceDefinitionTest.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 87f9a96 
> 
> Diff: https://reviews.apache.org/r/17503/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests for view classes.
> 
> All ambari-server unit tests pass :
> 
> Results :
> 
> Tests run: 1353, Failures: 0, Errors: 0, Skipped: 7
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>