[jira] [Commented] (TS-2618) IOBufferBlock::realloc()'s bounds check is wrong

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921325#comment-13921325 ] 

Leif Hedstrom commented on TS-2618:
-----------------------------------

Good to see you back with patches :). Nothing has changed btw, it's still primarily commit then review, so by all means, go ahead and start committing again. I'm assigning this to you.

> IOBufferBlock::realloc()'s bounds check is wrong
> ------------------------------------------------
>
>                 Key: TS-2618
>                 URL: https://issues.apache.org/jira/browse/TS-2618
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: William Bardwell
>             Fix For: 5.0.0
>
>
> Presumably this never fires, but:
>  if (i >= (int64_t) sizeof(ioBufAllocator))
>     return;
> looks wrong, it looks like i is an index into that array, so it should be i >= SIZE(ioBufAllocator))
> (SIZE() from ink_defs.h)



--
This message was sent by Atlassian JIRA
(v6.2#6252)