You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/22 21:46:57 UTC

[GitHub] [tvm] mbaret opened a new issue, #12548: [Tracking Issue] Refactor AOT executor codegen into IRModule -> IRModule form

mbaret opened a new issue, #12548:
URL: https://github.com/apache/tvm/issues/12548

   The AOT executor codegen has accumulated significant technical debt and dead code during its development, resulting in a component that is difficult to understand, test and extend. Refactoring it will improve code-quality and make it easier to introduce new features to expand the capabilities of AOT code generation.
   
   This refactor aims to observe the following principles:
   - Break the logic into passes with a single responsibility.
   - Introduce tests for the internal logic of AOT (not just end-to-end integration testing).
   - Remove side-channels and reduce the usage of 'magic attributes' to pass information.
   - De-duplicate logic where possible.
   
   ### PRs
   - [ ] P1. Introduce a standalone pass to lower a Relay main to TIR
   - [ ] P2. Introduce an analysis pass to create the 'function metadata'
   - [ ] P3. Introduce an analysis pass to create the 'executor metadata'
   - [ ] P4. Refactor AOTExecutorCodegenModule to use the new passes
   - [ ] P5. Remove the 'StorageRewrite' memory planning strategy (USMP only)
   - [ ] P?: Move context-specific passes out of the executor codegen (AnnotateUsedMemory/ConvertForLoopsToSerial)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] ekalda commented on issue #12548: [Tracking Issue] Refactor AOT executor codegen into IRModule -> IRModule form

Posted by "ekalda (via GitHub)" <gi...@apache.org>.

ekalda commented on issue #12548:
URL: https://github.com/apache/tvm/issues/12548#issuecomment-1479260791

   @areusch @mbaret is there a plan to continue this work? It looks like it's stuck in an awkward place where there is some duplicated code and a set of functions that are not used outside of the tests :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mbaret commented on issue #12548: [Tracking Issue] Refactor AOT executor codegen into IRModule -> IRModule form

Posted by "mbaret (via GitHub)" <gi...@apache.org>.

mbaret commented on issue #12548:
URL: https://github.com/apache/tvm/issues/12548#issuecomment-1479497837

   It's not my intention to continue with this refactor, I've instead been working on a Relax version of AOT. To avoid duplication, I could migrate the necessary passes to the unity branch and delete them from main. Let me know if this is the preferred course of action or whether there's any community interest in picking this refactor up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] ekalda commented on issue #12548: [Tracking Issue] Refactor AOT executor codegen into IRModule -> IRModule form

Posted by "ekalda (via GitHub)" <gi...@apache.org>.

ekalda commented on issue #12548:
URL: https://github.com/apache/tvm/issues/12548#issuecomment-1481506397

   Yes, I don't think the efforts to prototype Relax should justify bringing technical dept into TVM, so it would be better to remove the duplicated code. I don't think it is blocking anybody though, so it's not urgent. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org