You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2024/03/30 12:31:26 UTC
[PR] chore: fix deprecated IntegrationTest [pekko-persistence-jdbc]
Roiocam opened a new pull request, #165:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/165
IntegrationTest currently not working on my IDEA, It keeps complaining about NoClassFound.
After following the changes in the sbt release notes guidance, it works fine on my IDEA: https://eed3si9n.com/sbt-1.9.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: fix deprecated IntegrationTest [pekko-persistence-jdbc]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam merged PR #165:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: fix deprecated IntegrationTest [pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #165:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/165#issuecomment-2028074039
Any idea why the Check Code Style CI build is failing when it is looking for pekko-persistence-jdbc-core? This jar seems never to have been published before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: fix deprecated IntegrationTest [pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #165:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/165#discussion_r1545370580
##########
build.sbt:
##########
@@ -33,27 +33,37 @@ lazy val core = project
.in(file("core"))
.enablePlugins(MimaPlugin, ReproducibleBuildsPlugin)
.disablePlugins(SitePlugin)
- .configs(IntegrationTest.extend(Test))
- .settings(Defaults.itSettings)
.settings(
- name := "pekko-persistence-jdbc",
+ name := "pekko-persistence-jdbc-core",
Review Comment:
this is breaking our build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: fix deprecated IntegrationTest [pekko-persistence-jdbc]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #165:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/165#discussion_r1545372854
##########
build.sbt:
##########
@@ -33,27 +33,37 @@ lazy val core = project
.in(file("core"))
.enablePlugins(MimaPlugin, ReproducibleBuildsPlugin)
.disablePlugins(SitePlugin)
- .configs(IntegrationTest.extend(Test))
- .settings(Defaults.itSettings)
.settings(
- name := "pekko-persistence-jdbc",
+ name := "pekko-persistence-jdbc-core",
Review Comment:
Yes, I just investigated here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org