You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Dale Worley <dw...@pingtel.com> on 2005/07/22 15:55:37 UTC

Correcting EOL mistakes

If we're considering having "svn commit" correct the EOL characters of
files to match the svn:eol-style value, perhaps we should consider it
a user-interaction configuration matter rather than an attribute of a
file.  After all, it is more likely that one user will want to deal
all files in that way (or not) than that all users will want to deal
with one particular file in that way (or not).

So let me propose that "correct EOL characters" be a
user-configuration option, with three values:

no - (the default) a mis-match between the EOL characters and
svn:eol-style is treated as an error and aborts the commit (as it is
now)

yes - mis-matches are automatically corrected with a message output
for each file that is corrected (unless --quiet is specified)

query - queries the user for each file, and in response acts as "no"
or "yes" accordingly -- unless --non-interactive is in effect, in which
case it is treated as "no".

It seems like that gives everybody what they want, is
upward-compatible with the current scheme, and fits smoothly with all
the defined variants of commands.

Dale


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Correcting EOL mistakes

Posted by Greg Hudson <gh...@MIT.EDU>.
On Fri, 2005-07-22 at 11:55 -0400, Dale Worley wrote:
> So let me propose that "correct EOL characters" be a
> user-configuration option, with three values:

Goodness, no.  Take a step back and imagine an administrator going
through the thousands and thousands of pointless configuration options
which would be in Subversion in ten years if we adopted this philosophy
every time there was a minor dispute on the dev list.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org