You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/02/05 13:25:53 UTC

[jira] [Created] (LUCENE-3752) move preflexrw to lucene3x package

move preflexrw to lucene3x package
----------------------------------

                 Key: LUCENE-3752
                 URL: https://issues.apache.org/jira/browse/LUCENE-3752
             Project: Lucene - Java
          Issue Type: Task
            Reporter: Robert Muir
             Fix For: 4.0


Currently there are a lot of things made public in lucene3x codec, but all marked internal/experimental/deprecated.

A lot of this is just so our test codec (preflexrw) can subclass it. I think we should just move it to the same
package, then it call all be package-private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3752) move preflexrw to lucene3x package

Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3752.
---------------------------------

    Resolution: Fixed

Committed revision 1240750.
                
> move preflexrw to lucene3x package
> ----------------------------------
>
>                 Key: LUCENE-3752
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3752
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Currently there are a lot of things made public in lucene3x codec, but all marked internal/experimental/deprecated.
> A lot of this is just so our test codec (preflexrw) can subclass it. I think we should just move it to the same
> package, then it call all be package-private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3752) move preflexrw to lucene3x package

Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200784#comment-13200784 ] 

Simon Willnauer commented on LUCENE-3752:
-----------------------------------------

+1
                
> move preflexrw to lucene3x package
> ----------------------------------
>
>                 Key: LUCENE-3752
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3752
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Currently there are a lot of things made public in lucene3x codec, but all marked internal/experimental/deprecated.
> A lot of this is just so our test codec (preflexrw) can subclass it. I think we should just move it to the same
> package, then it call all be package-private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3752) move preflexrw to lucene3x package

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200792#comment-13200792 ] 

Robert Muir commented on LUCENE-3752:
-------------------------------------

Thanks for the comments guys, Ill do the svn moves and make it all package-private (Except the codec).

I think it was especially confusing to see SegmentTerm[Enum/Docs/Positions] that resemble 3.x apis 
as public classes in 4.0 (even if they are deprecated/experimental/internal/full of warnings)...
they are really internal implementation details :)
                
> move preflexrw to lucene3x package
> ----------------------------------
>
>                 Key: LUCENE-3752
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3752
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Currently there are a lot of things made public in lucene3x codec, but all marked internal/experimental/deprecated.
> A lot of this is just so our test codec (preflexrw) can subclass it. I think we should just move it to the same
> package, then it call all be package-private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3752) move preflexrw to lucene3x package

Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200769#comment-13200769 ] 

Michael McCandless commented on LUCENE-3752:
--------------------------------------------

+1
                
> move preflexrw to lucene3x package
> ----------------------------------
>
>                 Key: LUCENE-3752
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3752
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>
> Currently there are a lot of things made public in lucene3x codec, but all marked internal/experimental/deprecated.
> A lot of this is just so our test codec (preflexrw) can subclass it. I think we should just move it to the same
> package, then it call all be package-private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org