You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "sjmshsh (via GitHub)" <gi...@apache.org> on 2023/09/14 04:25:12 UTC

[GitHub] [dubbo-kubernetes] sjmshsh opened a new pull request, #25: fix docs, fix license, fix lint, fix test

sjmshsh opened a new pull request, #25:
URL: https://github.com/apache/dubbo-kubernetes/pull/25

   ## What is the purpose of the change
   
   XXXXX
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   * [ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   * [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   * [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   * [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
   * [ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-kubernetes] codecov-commenter commented on pull request #25: fix docs, fix license, fix lint, fix test,enhance install

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25:
URL: https://github.com/apache/dubbo-kubernetes/pull/25#issuecomment-1720485828

   ## [Codecov](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#25](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b966cad) into [master](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/6d0d795a7dc0945ff158b5fce84e3055b0790592?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6d0d795) will **increase** coverage by `0.19%`.
   > Report is 14 commits behind head on master.
   > The diff coverage is `45.83%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master      #25      +/-   ##
   ==========================================
   + Coverage   47.25%   47.45%   +0.19%     
   ==========================================
     Files         117      150      +33     
     Lines        6675     9768    +3093     
     Branches       41       41              
   ==========================================
   + Hits         3154     4635    +1481     
   - Misses       3211     4603    +1392     
   - Partials      310      530     +220     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [app/dubboctl/cmd/completion\_util.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2NtZC9jb21wbGV0aW9uX3V0aWwuZ28=) | `0.00% <0.00%> (ø)` | |
   | [app/dubboctl/cmd/manifest\_diff.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2NtZC9tYW5pZmVzdF9kaWZmLmdv) | `59.80% <ø> (ø)` | |
   | [app/dubboctl/cmd/profile\_diff.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2NtZC9wcm9maWxlX2RpZmYuZ28=) | `79.59% <ø> (ø)` | |
   | [app/dubboctl/cmd/profile\_list.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2NtZC9wcm9maWxlX2xpc3QuZ28=) | `91.83% <ø> (ø)` | |
   | [app/dubboctl/internal/dubbo/deployer.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2ludGVybmFsL2R1YmJvL2RlcGxveWVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [app/dubboctl/internal/dubbo/errors.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2ludGVybmFsL2R1YmJvL2Vycm9ycy5nbw==) | `0.00% <0.00%> (ø)` | |
   | [app/dubboctl/internal/kube/component.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2ludGVybmFsL2t1YmUvY29tcG9uZW50Lmdv) | `49.56% <ø> (ø)` | |
   | [app/dubboctl/internal/kube/object.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2ludGVybmFsL2t1YmUvb2JqZWN0Lmdv) | `84.03% <ø> (ø)` | |
   | [app/dubboctl/internal/kube/operator.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2ludGVybmFsL2t1YmUvb3BlcmF0b3IuZ28=) | `0.00% <0.00%> (ø)` | |
   | [app/dubboctl/internal/kube/port\_foward.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBwL2R1YmJvY3RsL2ludGVybmFsL2t1YmUvcG9ydF9mb3dhcmQuZ28=) | `0.00% <ø> (ø)` | |
   | ... and [61 more](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/25/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-kubernetes] chickenlj merged pull request #25: fix docs, fix license, fix lint, fix test,enhance install

Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #25:
URL: https://github.com/apache/dubbo-kubernetes/pull/25


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org