You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brock Noland <br...@cloudera.com> on 2014/02/20 17:59:30 UTC
Review Request 18314: SENTRY-119 - Reduce tarball size by excluding third
party directory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18314/
-----------------------------------------------------------
Review request for sentry and Gregory Chanan.
Bugs: SENTRY-119
https://issues.apache.org/jira/browse/SENTRY-119
Repository: sentry
Description
-------
Tested tarball and it looks good.
Diffs
-----
sentry-dist/pom.xml 1190fe1
sentry-dist/src/main/assembly/src.xml 323488b
Diff: https://reviews.apache.org/r/18314/diff/
Testing
-------
Thanks,
Brock Noland
Re: Review Request 18314: SENTRY-119 - Reduce tarball size by excluding
third party directory
Posted by Gregory Chanan <gc...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18314/#review35081
-----------------------------------------------------------
Ship it!
Ship It!
- Gregory Chanan
On Feb. 20, 2014, 4:59 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18314/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 4:59 p.m.)
>
>
> Review request for sentry and Gregory Chanan.
>
>
> Bugs: SENTRY-119
> https://issues.apache.org/jira/browse/SENTRY-119
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Tested tarball and it looks good.
>
>
> Diffs
> -----
>
> sentry-dist/pom.xml 1190fe1
> sentry-dist/src/main/assembly/src.xml 323488b
>
> Diff: https://reviews.apache.org/r/18314/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 18314: SENTRY-119 - Reduce tarball size by excluding
third party directory
Posted by Brock Noland <br...@cloudera.com>.
> On Feb. 20, 2014, 9:36 p.m., Gregory Chanan wrote:
> > sentry-dist/src/main/assembly/src.xml, line 31
> > <https://reviews.apache.org/r/18314/diff/1/?file=499004#file499004line31>
> >
> > just curious -- why call the file (artifact? not sure that's the correct word) apache-sentry when all the other artifacts are just sentry?
No real reason except I prefer the tarball to start with apache. Many apache projects do that.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18314/#review35076
-----------------------------------------------------------
On Feb. 20, 2014, 4:59 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18314/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 4:59 p.m.)
>
>
> Review request for sentry and Gregory Chanan.
>
>
> Bugs: SENTRY-119
> https://issues.apache.org/jira/browse/SENTRY-119
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Tested tarball and it looks good.
>
>
> Diffs
> -----
>
> sentry-dist/pom.xml 1190fe1
> sentry-dist/src/main/assembly/src.xml 323488b
>
> Diff: https://reviews.apache.org/r/18314/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 18314: SENTRY-119 - Reduce tarball size by excluding
third party directory
Posted by Gregory Chanan <gc...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18314/#review35076
-----------------------------------------------------------
sentry-dist/src/main/assembly/src.xml
<https://reviews.apache.org/r/18314/#comment65469>
just curious -- why call the file (artifact? not sure that's the correct word) apache-sentry when all the other artifacts are just sentry?
- Gregory Chanan
On Feb. 20, 2014, 4:59 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18314/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 4:59 p.m.)
>
>
> Review request for sentry and Gregory Chanan.
>
>
> Bugs: SENTRY-119
> https://issues.apache.org/jira/browse/SENTRY-119
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Tested tarball and it looks good.
>
>
> Diffs
> -----
>
> sentry-dist/pom.xml 1190fe1
> sentry-dist/src/main/assembly/src.xml 323488b
>
> Diff: https://reviews.apache.org/r/18314/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>