You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by oeegee <gi...@git.apache.org> on 2017/02/13 04:26:53 UTC
[GitHub] zeppelin pull request #2012: add zeppelin.dep.localrepo in zeppelin config
GitHub user oeegee opened a pull request:
https://github.com/apache/zeppelin/pull/2012
add zeppelin.dep.localrepo in zeppelin config
<property>
<name>zeppelin.dep.localrepo</name>
<value>local-repo</value>
<description>Local repository for dependency loader</description>
</property>
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AAPlus/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2012.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2012
----
commit 2c4ff88226542df348339e8c2fd4d0714085602a
Author: Daniel Jeon <oe...@gmail.com>
Date: 2017-02-13T04:25:22Z
add zeppelin.dep.localrepo in zeppelin config
<property>
<name>zeppelin.dep.localrepo</name>
<value>local-repo</value>
<description>Local repository for dependency loader</description>
</property>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2012: add zeppelin.dep.localrepo in zeppelin config
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2012
Thanks @oeegee Looks good to me.
Merge into branch-0.7 and master if there are no comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2012: add zeppelin.dep.localrepo in zeppelin config
Posted by oeegee <gi...@git.apache.org>.
Github user oeegee commented on the issue:
https://github.com/apache/zeppelin/pull/2012
If you refer to the source below, it should be added as ZEPPELIN_DEP_LOCALREPO ".
https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
---------------------------------------------------------------------------
608 : ZEPPELIN_DEP_LOCALREPO("zeppelin.dep.localrepo", "local-repo"),
---------------------------------------------------------------------------
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2012: add zeppelin.dep.localrepo in zeppelin config
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2012
@oeegee Not sure I got your point well, but I just suggested you to update [this config file](https://github.com/apache/zeppelin/blob/master/docs/install/configuration.md#zeppelin-properties) accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2012: add zeppelin.dep.localrepo in zeppelin config
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2012
@oeegee Thank you for the contribution. If we can change this property value via zeppelin-site.xml, then how about adding this property info to [this configuration table](https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/install/configuration.html#zeppelin-properties) as well? This file is located in [here](https://github.com/apache/zeppelin/blob/master/docs/install/configuration.md) :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2012: add zeppelin.dep.localrepo in zeppelin config
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---