You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/11 15:12:49 UTC
[GitHub] [kafka] blcksrx opened a new pull request, #12400: KAFKA-13648: KRaft ClusterInstance does not allow for deferred start
blcksrx opened a new pull request, #12400:
URL: https://github.com/apache/kafka/pull/12400
This issue happens cause the `cluster.startup()` invoked already and the solution is just check the `clusterConfig.isAutoStart` in the `BeforeTestExecutionCallback`.
In addition I believe checking just a broker state is not sufficient and it's better to invoke `cluster.waitForReadyBrokers()` instead but I didn't change it, cause it was out of scope of the issue.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] blcksrx commented on pull request #12400: KAFKA-13648: KRaft ClusterInstance does not allow for deferred start
Posted by GitBox <gi...@apache.org>.
blcksrx commented on PR #12400:
URL: https://github.com/apache/kafka/pull/12400#issuecomment-1259349410
Just checking what is the status of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #12400: KAFKA-13648: KRaft ClusterInstance does not allow for deferred start
Posted by GitBox <gi...@apache.org>.
dengziming commented on PR #12400:
URL: https://github.com/apache/kafka/pull/12400#issuecomment-1183120119
Thank you for this PR @blcksrx , the change looks reasonable, for my understanding, what is the motivation for this change? did you find the AutoStart is useful while working on additional tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] blcksrx commented on pull request #12400: KAFKA-13648: KRaft ClusterInstance does not allow for deferred start
Posted by GitBox <gi...@apache.org>.
blcksrx commented on PR #12400:
URL: https://github.com/apache/kafka/pull/12400#issuecomment-1183127918
In situations, such as different configs for brokers, this `AutoStart` is helpful. As an example, I believe this ticket needs flexibility [KAFKA-12617](https://issues.apache.org/jira/browse/KAFKA-12617) of `AutoStart.No`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #12400: KAFKA-13648: KRaft ClusterInstance does not allow for deferred start
Posted by GitBox <gi...@apache.org>.
cmccabe commented on PR #12400:
URL: https://github.com/apache/kafka/pull/12400#issuecomment-1203275395
This does look right to me but let me check with @mumrah . Thanks, @blcksrx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org