You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by ardlema <gi...@git.apache.org> on 2015/06/16 09:37:02 UTC
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
GitHub user ardlema opened a pull request:
https://github.com/apache/metamodel/pull/27
Added COUNTER data type support. fixes #METAMODEL-149
Added support for COUNTER data type format in Cassandra module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ardlema/metamodel METAMODEL-149
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 17109fc2e46bcb76920651ef61ed4aba0a14b743
Author: Alberto Rodriguez <ar...@stratio.com>
Date: 2015-06-12T09:29:38Z
Added COUNTER data type support. fixes #METAMODEL-149
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112382524
Cool, I'll create it.
Are you happy to close this PR then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112370627
Wut? How did you add a new commit without Github realizing it? Amended commit?
(I only know because I was about to add a comment about the missing isConfigured, and you had added it when I submitted :))
- By the way, way to do away with those isConfigured with some kind of mock setup? It's a quite a shame to miss the automated testing for all of CassandraDataContext.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112694142
Sure. Already done ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112497829
Yup!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112371244
My bad! Forgot to add the isConfigured() check in the new test that I added.
It's great to have travis-ci!! ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112443414
@kaspersorensen are you happy with the patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112382635
Looks good to me! :-)
On 16 June 2015 12:40:59 CEST, Alberto Rodriguez <no...@github.com> wrote:
>Cool, I'll create it.
>
>Are you happy to close this PR then?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/apache/metamodel/pull/27#issuecomment-112382524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112381437
Yes, I ammended the last commit because I knew that I was working on my own in the branch.
Should we create a new jira to address the embedded Cassandra server stuff? I'm willing to make that changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112685935
Thank you for your comments guys! I'll commit the changes to the apache repo and close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112443649
@LosD I've just created a jira issue: https://issues.apache.org/jira/browse/METAMODEL-154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112374170
A biiiit dangerous amending stuff already pushed, if anyone had tried to work from the branch, their branch could easily have been corrupted... But I guess this is so limited in scope that the danger was pretty low. :)
Very good idea with the embedded Cassandra server. It might be a bit too big a change for this PR, but we might want to do it either by itself, or along with other changes later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112365445
The patch looks good to me. But Travis is failing it seems. Can you check it out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112382406
Hmmm, yeah I guess that would make sense.
On 16 June 2015 12:35:30 CEST, Alberto Rodriguez <no...@github.com> wrote:
>Yes, I ammended the last commit because I knew that I was working on my
>own in the branch.
>
>Should we create a new jira to address the embedded Cassandra server
>stuff? I'm willing to make that changes.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/apache/metamodel/pull/27#issuecomment-112381437
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112444893
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112372735
@LosD you are right I ammended my last commit.
We might use an embedded Cassandra server to run the tests: https://github.com/jsevellec/cassandra-unit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Added COUNTER data type support. fixes #ME...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/27#issuecomment-112692707
Oh one little thing ... Could you also update CHANGES.md? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---