[GitHub] [incubator-superset] rusackas commented on pull request #10747: Rejiggering some dependencies, trying to get CI to pass

[GitBox <gi...@apache.org>]

rusackas commented on pull request #10747:
URL: https://github.com/apache/incubator-superset/pull/10747#issuecomment-684178411


   > lgtm, although i've never known if `@types` requirements should be in dependencies or devDependencies. We should probably be consistent (especially since i'm sure `@types/enzyme` isn't needed for the production app)
   
   I keep wondering the same thing... then I google around to see what others say/do, and wind up just as confused :P 
   
   I'm also unsure about the `fsevents` optional dependency. I just made it e dependency for now, and it seems to be working. 
   
   I'm trying not to rock the boat too hard on this PR, but once this goes in, I'll open subsequent PRs to remove `fsevents` and move `@types` to devDependencies, and see how those play out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org