[GitHub] [cloudstack] nvazquez commented on a change in pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #5076:
URL: https://github.com/apache/cloudstack/pull/5076#discussion_r646628034



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/ScsiDiskControllerType.java
##########
@@ -17,8 +17,10 @@
 package com.cloud.hypervisor.vmware.mo;
 
 public interface ScsiDiskControllerType {
-    public final static String LSILOGIC_PARALLEL = "lsilogic";
-    public final static String LSILOGIC_SAS = "lsisas1068";
-    public final static String BUSLOGIC = "buslogic";
-    public final static String VMWARE_PARAVIRTUAL = "pvscsi";
+    String LSILOGIC_PARALLEL = "lsilogic";
+    String LSILOGIC_SAS = "lsilogicsas";
+    String LSILOGIC_SAS_1068 = "lsisas1068";

Review comment:
       @sureshanaparti that is correct but those strings are internally mapped by Vmware to the LSI Logic SAS controller. However, I could not find what the difference is between those values on the Vmware documentation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org