You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2012/06/26 18:04:44 UTC

[jira] [Updated] (HIVE-3048) Collect_set Aggregate does uneccesary check for value.

     [ https://issues.apache.org/jira/browse/HIVE-3048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-3048:
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.10.0
           Status: Resolved  (was: Patch Available)

Committed to trunk.
                
> Collect_set Aggregate does uneccesary check for value.
> ------------------------------------------------------
>
>                 Key: HIVE-3048
>                 URL: https://issues.apache.org/jira/browse/HIVE-3048
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.8.1
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3048.patch.1.txt
>
>
> Sets already de-duplicate for free no need for existence check.
> {noformat}
>      private void putIntoSet(Object p, MkArrayAggregationBuffer myagg) {
>       if (myagg.container.contains(p))
>         return;
>        Object pCopy = ObjectInspectorUtils.copyToStandardObject(p,
>            this.inputOI);
>        myagg.container.add(pCopy);
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira