You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ps...@apache.org on 2013/12/26 21:03:11 UTC

svn commit: r1553569 - in /commons/proper/pool/trunk/src: changes/ main/java/org/apache/commons/pool2/impl/

Author: psteitz
Date: Thu Dec 26 20:03:11 2013
New Revision: 1553569

URL: http://svn.apache.org/r1553569
Log:
Added change warnings on MBean interfaces; clarified compat statements.

Modified:
    commons/proper/pool/trunk/src/changes/changes.xml
    commons/proper/pool/trunk/src/changes/release-notes.vm
    commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java
    commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java
    commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolMXBean.java

Modified: commons/proper/pool/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/changes/changes.xml?rev=1553569&r1=1553568&r2=1553569&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/changes/changes.xml (original)
+++ commons/proper/pool/trunk/src/changes/changes.xml Thu Dec 26 20:03:11 2013
@@ -66,7 +66,7 @@ including bugfixes and test case improve
     </action>
     <action dev="markt" type="add">
       Include the number of times an object has been borrowed from the Pool when
-      the DefaultPooledObject wrapper is used.
+      the DefaultPooledObject wrapper is used and expose this property via JMX.
     </action>
     <action issue="POOL-245" dev="markt" type="fix" due-to="Bruno P. Kinoshita">
       Remove a duplicate null check and fix some typos in PoolUtils.

Modified: commons/proper/pool/trunk/src/changes/release-notes.vm
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/changes/release-notes.vm?rev=1553569&r1=1553568&r2=1553569&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/changes/release-notes.vm (original)
+++ commons/proper/pool/trunk/src/changes/release-notes.vm Thu Dec 26 20:03:11 2013
@@ -19,11 +19,13 @@
 The ${developmentTeam} is pleased to announce the release of ${project.name} ${version}.
 
 Apache Commons Pool provides an object-pooling API and a number of object pool implementations.
-Version 2.1 is source and binary compatible with version 2.0, but not with the 1.x series.
 Version 2 contains a completely re-written pooling implementation compared to the 1.x series.
 In addition to performance and scalability improvements, version 2 includes robust instance
 tracking and pool monitoring. Version 2 requires JDK level 1.6 or above. 
 
+No client code changes are required to migrate from version 2.0 to 2.1.  Users of version 1.x
+should consult the migration guide on the Commons Pool web site.
+
 ## N.B. the available variables are described here:
 ## http://maven.apache.org/plugins/maven-changes-plugin/examples/using-a-custom-announcement-template.html
 ##

Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java?rev=1553569&r1=1553568&r2=1553569&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java (original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java Thu Dec 26 20:03:11 2013
@@ -19,6 +19,9 @@ package org.apache.commons.pool2.impl;
 /**
  * The interface that defines the information about pooled objects that will be
  * exposed via JMX.
+ * 
+ * NOTE: This interface is subject to change between major version releases
+ * of commons pool.
  *
  * @since 2.0
  */

Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java?rev=1553569&r1=1553568&r2=1553569&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java (original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java Thu Dec 26 20:03:11 2013
@@ -21,6 +21,9 @@ import java.util.Map;
 
 /**
  * Defines the methods that will be made available via JMX.
+ * 
+ * NOTE: This interface is subject to change between major version releases
+ * of commons pool.
  *
  * @param <K> The type of keys maintained by the pool.
  *

Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolMXBean.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolMXBean.java?rev=1553569&r1=1553568&r2=1553569&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolMXBean.java (original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPoolMXBean.java Thu Dec 26 20:03:11 2013
@@ -20,6 +20,9 @@ import java.util.Set;
 
 /**
  * Defines the methods that will be made available via JMX.
+ * 
+ * NOTE: This interface is subject to change between major version releases
+ * of commons pool.
  *
  * @version $Revision: $
  *



Re: svn commit: r1553569 - in /commons/proper/pool/trunk/src: changes/ main/java/org/apache/commons/pool2/impl/

Posted by Phil Steitz <ph...@gmail.com>.
On 12/26/13, 3:37 PM, Mark Thomas wrote:
> On 26/12/2013 20:03, psteitz@apache.org wrote:
>> Author: psteitz
>> Date: Thu Dec 26 20:03:11 2013
>> New Revision: 1553569
>>
>> URL: http://svn.apache.org/r1553569
>> Log:
>> Added change warnings on MBean interfaces; clarified compat statements.
> <snip/>
>
>> Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java
>> URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java?rev=1553569&r1=1553568&r2=1553569&view=diff
>> ==============================================================================
>> --- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java (original)
>> +++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java Thu Dec 26 20:03:11 2013
>> @@ -19,6 +19,9 @@ package org.apache.commons.pool2.impl;
>>  /**
>>   * The interface that defines the information about pooled objects that will be
>>   * exposed via JMX.
>> + * 
>> + * NOTE: This interface is subject to change between major version releases
>> + * of commons pool.
> Any class can change between major versions. Don't you mean point
> releases here? Granted, a change between point releases is unlikely (I'd
> expect between minor releases to be the norm) but I can imagine a few
> extreme scenarios where a change between point releases could happen.

What I meant to indicate was that it could change *strictly* between
major releases, i.e. a point release could include a change.  Sorry
I was not clear enough.  I will fix this / include any changes
anyone else commits if I cut another RC for 2.1. 

Phil
>
> Mark
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1553569 - in /commons/proper/pool/trunk/src: changes/ main/java/org/apache/commons/pool2/impl/

Posted by Mark Thomas <ma...@apache.org>.
On 26/12/2013 20:03, psteitz@apache.org wrote:
> Author: psteitz
> Date: Thu Dec 26 20:03:11 2013
> New Revision: 1553569
> 
> URL: http://svn.apache.org/r1553569
> Log:
> Added change warnings on MBean interfaces; clarified compat statements.

<snip/>

> Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java
> URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java?rev=1553569&r1=1553568&r2=1553569&view=diff
> ==============================================================================
> --- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java (original)
> +++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/DefaultPooledObjectInfoMBean.java Thu Dec 26 20:03:11 2013
> @@ -19,6 +19,9 @@ package org.apache.commons.pool2.impl;
>  /**
>   * The interface that defines the information about pooled objects that will be
>   * exposed via JMX.
> + * 
> + * NOTE: This interface is subject to change between major version releases
> + * of commons pool.

Any class can change between major versions. Don't you mean point
releases here? Granted, a change between point releases is unlikely (I'd
expect between minor releases to be the norm) but I can imagine a few
extreme scenarios where a change between point releases could happen.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org