You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by ZenPylon <gi...@git.apache.org> on 2017/09/18 16:34:21 UTC
[GitHub] cordova-plugin-camera pull request #284: Update CameraProxy.js
GitHub user ZenPylon opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/284
Update CameraProxy.js
Remove audio flag from getUserMedia on the browser. Including audio resulted in some nasty audio feedback, and audio isn't really needed for taking pictures anyway.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ZenPylon/cordova-plugin-camera patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/284.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #284
----
commit 2612cd2a2c030463619c29a94e83876bbe13c531
Author: Andrew Decker <aj...@gmail.com>
Date: 2017-09-18T16:33:33Z
Update CameraProxy.js
Remove audio flag from getUserMedia on the browser. Including audio resulted in some nasty audio feedback, and audio isn't really needed for taking pictures anyway.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org