[GitHub] [beam] lukecwik commented on a change in pull request #16263: [BEAM-13015] Migrate all user state and side implementations to support caching.

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #16263:
URL: https://github.com/apache/beam/pull/16263#discussion_r770980561



##########
File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/stream/PrefetchableIterable.java
##########
@@ -20,6 +20,9 @@
 /** An {@link Iterable} that returns {@link PrefetchableIterator}s. */
 public interface PrefetchableIterable<T> extends Iterable<T> {
 
+  /** Ensures that the next iterator returned has been prefetched. */
+  void prefetch();

Review comment:
       It was errorprone with the previous setup where we were effectively discarding the prefetched iterator making it such that the iterable needed to handle the caching. This seems to be much safer since the iterable is usually stored.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org