You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2014/07/07 22:29:50 UTC
Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
-----------------------------------------------------------
Review request for hive, Sushanth Sowmyan and Thejas Nair.
Bugs: HIVE-7353
https://issues.apache.org/jira/browse/HIVE-7353
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7353
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java acef599
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
Diff: https://reviews.apache.org/r/23320/diff/
Testing
-------
Manual testing using Yourkit.
Thanks,
Vaibhav Gumashta
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review47551
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/23320/#comment83558>
I cannot believe that it was not static. Other threadlocals below(threadLocalTxn, threadLocalConf) also should be static field.
And, 'final' modifiers could be applied.
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
<https://reviews.apache.org/r/23320/#comment83557>
This makes the object store shared between two or more threads, which will introduce transaction problem in it.
- Navis Ryu
On July 7, 2014, 8:29 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 8:29 p.m.)
>
>
> Review request for hive, Sushanth Sowmyan and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java acef599
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review47550
-----------------------------------------------------------
One general question I had is with this scheme is, could background threads get same rawStore instance, and thus see concurrency issue? I wasnt sure if foreground threads could fork multiple background threads that run concurrently?
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/23320/#comment83555>
Remove tab
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
<https://reviews.apache.org/r/23320/#comment83556>
Will it return null if remote mode? If so, we could put checks in the code to skip it, or at least document the method to mention that, as this wouldn't make sense then?
- Szehon Ho
On July 7, 2014, 8:29 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 8:29 p.m.)
>
>
> Review request for hive, Sushanth Sowmyan and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java acef599
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
> On Aug. 7, 2014, 12:02 a.m., Szehon Ho wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 252
> > <https://reviews.apache.org/r/23320/diff/2/?file=653814#file653814line252>
> >
> > It can still be final even if static.
Yup, can be made final now. In the previous patch I was setting it in background thread from the handler thread, that's why had to keep it non-final.
> On Aug. 7, 2014, 12:02 a.m., Szehon Ho wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 260
> > <https://reviews.apache.org/r/23320/diff/2/?file=653814#file653814line260>
> >
> > Doesnt look like these methods are used?
setRawStore won't be used now. getRawStore is used. removeRawStore might be a useful encapsulation.
- Vaibhav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review49832
-----------------------------------------------------------
On Aug. 6, 2014, 4:11 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 4:11 p.m.)
>
>
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
> service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
> service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
> service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review49832
-----------------------------------------------------------
Looks better technically, just some minor style and cleanup comment below. I also think the new conf's description can be improved as per Lefty's suggestion.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/23320/#comment87220>
Fix ws
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/23320/#comment87214>
It can still be final even if static.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/23320/#comment87213>
Doesnt look like these methods are used?
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
<https://reviews.apache.org/r/23320/#comment87215>
End-paren should go on next line
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
<https://reviews.apache.org/r/23320/#comment87217>
Can we move the javadoc to before annotation?
service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java
<https://reviews.apache.org/r/23320/#comment87218>
We can refer to the map variable here.
- Szehon Ho
On Aug. 6, 2014, 4:11 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 4:11 p.m.)
>
>
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
> service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
> service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
> service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Lefty Leverenz <le...@gmail.com>.
> On Aug. 6, 2014, 7:24 p.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1457
> > <https://reviews.apache.org/r/23320/diff/2/?file=653813#file653813line1457>
> >
> > Please specify time units.
> >
> > Also, what does #min mean here -- minimum? (If so, is it set by some other parameter?)
> >
> > Since this is keepalive.time, at first I thought #min meant minutes but that makes no sense at all.
Thanks, good fix.
> On Aug. 6, 2014, 7:24 p.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1482
> > <https://reviews.apache.org/r/23320/diff/2/?file=653813#file653813line1482>
> >
> > Please specify time units.
> >
> > Also, what does #min mean and is it set by some other parameter?
Thanks again.
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review49792
-----------------------------------------------------------
On Aug. 12, 2014, 11:33 a.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2014, 11:33 a.m.)
>
>
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
> service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
> service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
> service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review49792
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/23320/#comment87122>
Please specify time units.
Also, what does #min mean here -- minimum? (If so, is it set by some other parameter?)
Since this is keepalive.time, at first I thought #min meant minutes but that makes no sense at all.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/23320/#comment87123>
Please specify time units.
Also, what does #min mean and is it set by some other parameter?
- Lefty Leverenz
On Aug. 6, 2014, 4:11 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 4:11 p.m.)
>
>
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
> service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
> service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
> service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
> On Aug. 26, 2014, 6:17 p.m., Szehon Ho wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 5229
> > <https://reviews.apache.org/r/23320/diff/5/?file=669421#file669421line5229>
> >
> > Can we remove these whitespace change from the patch? I guess its good to cleanup, but I'm not 100% sure if they are all right. Some place like here the indent is gone, elsewhere they are added, etc..
> >
> > Also maybe we can remove Hive.java cleanup from this patch as well?
Sorry about this. Editor settings were adding the cleanup.
- Vaibhav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review51558
-----------------------------------------------------------
On Aug. 26, 2014, 5:10 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 5:10 p.m.)
>
>
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 06d7595
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 0693039
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e387b8f
> ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java bc9254c
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 9798cf3
> service/src/java/org/apache/hive/service/cli/CLIService.java d2cdfc1
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java bc0a02c
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d573592
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 37b05fc
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
> service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java c380b69
> service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
> service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review51558
-----------------------------------------------------------
Code changes look good to me. Some nit below.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/23320/#comment89963>
Can we remove these whitespace change from the patch? I guess its good to cleanup, but I'm not 100% sure if they are all right. Some place like here the indent is gone, elsewhere they are added, etc..
Also maybe we can remove Hive.java cleanup from this patch as well?
- Szehon Ho
On Aug. 26, 2014, 5:10 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 5:10 p.m.)
>
>
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 06d7595
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 0693039
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e387b8f
> ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java bc9254c
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 9798cf3
> service/src/java/org/apache/hive/service/cli/CLIService.java d2cdfc1
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java bc0a02c
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d573592
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 37b05fc
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
> service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java c380b69
> service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
> service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
-----------------------------------------------------------
(Updated Aug. 26, 2014, 5:10 p.m.)
Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
Bugs: HIVE-7353
https://issues.apache.org/jira/browse/HIVE-7353
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7353
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 06d7595
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 0693039
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e387b8f
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java bc9254c
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 9798cf3
service/src/java/org/apache/hive/service/cli/CLIService.java d2cdfc1
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java bc0a02c
service/src/java/org/apache/hive/service/cli/session/SessionManager.java d573592
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 37b05fc
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java c380b69
service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc
Diff: https://reviews.apache.org/r/23320/diff/
Testing
-------
Manual testing using Yourkit.
Thanks,
Vaibhav Gumashta
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
-----------------------------------------------------------
(Updated Aug. 25, 2014, 7:15 p.m.)
Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
Bugs: HIVE-7353
https://issues.apache.org/jira/browse/HIVE-7353
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7353
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 06d7595
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 0693039
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e387b8f
service/src/java/org/apache/hive/service/cli/CLIService.java d2cdfc1
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
service/src/java/org/apache/hive/service/cli/session/HiveSession.java 9785e95
service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java eee1cc6
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java bc0a02c
service/src/java/org/apache/hive/service/cli/session/SessionManager.java d573592
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java 37b05fc
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java c380b69
service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
Diff: https://reviews.apache.org/r/23320/diff/
Testing
-------
Manual testing using Yourkit.
Thanks,
Vaibhav Gumashta
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 11:33 a.m.)
Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
Bugs: HIVE-7353
https://issues.apache.org/jira/browse/HIVE-7353
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7353
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
Diff: https://reviews.apache.org/r/23320/diff/
Testing
-------
Manual testing using Yourkit.
Thanks,
Vaibhav Gumashta
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review50174
-----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
<https://reviews.apache.org/r/23320/#comment87765>
I'll move this back to HiveSessionImpl#open as this won't pick the doAs setting since open goes through the appropriate proxy (which has UGI.doAs).
- Vaibhav Gumashta
On Aug. 6, 2014, 4:11 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23320/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 4:11 p.m.)
>
>
> Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
>
>
> Bugs: HIVE-7353
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-7353
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
> service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
> service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
> service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
> service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
> service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23320/diff/
>
>
> Testing
> -------
>
> Manual testing using Yourkit.
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 4:11 p.m.)
Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
Bugs: HIVE-7353
https://issues.apache.org/jira/browse/HIVE-7353
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7353
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
Diff: https://reviews.apache.org/r/23320/diff/
Testing
-------
Manual testing using Yourkit.
Thanks,
Vaibhav Gumashta
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 4:11 p.m.)
Review request for hive, Sushanth Sowmyan, Szehon Ho, and Thejas Nair.
Bugs: HIVE-7353
https://issues.apache.org/jira/browse/HIVE-7353
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7353
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
Diff: https://reviews.apache.org/r/23320/diff/
Testing
-------
Manual testing using Yourkit.
Thanks,
Vaibhav Gumashta
Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks
JDOPersistanceManager
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 3:46 p.m.)
Review request for hive, Sushanth Sowmyan and Thejas Nair.
Bugs: HIVE-7353
https://issues.apache.org/jira/browse/HIVE-7353
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-7353
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java ff282c5
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 760777a
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443
service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java de54ca1
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java b39d64d
service/src/java/org/apache/hive/service/cli/session/SessionManager.java c2f0495
service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java b009a88
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java be2eb01
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 98d75b5
service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java PRE-CREATION
service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java PRE-CREATION
Diff: https://reviews.apache.org/r/23320/diff/
Testing
-------
Manual testing using Yourkit.
Thanks,
Vaibhav Gumashta