You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "bruno rovagnati (JIRA)" <ji...@apache.org> on 2008/05/31 03:45:45 UTC

[jira] Created: (SHINDIG-322) bug when concatenating inline JS (when js compress == false)

bug when concatenating inline JS (when js compress == false)
------------------------------------------------------------

                 Key: SHINDIG-322
                 URL: https://issues.apache.org/jira/browse/SHINDIG-322
             Project: Shindig
          Issue Type: Bug
          Components: Gadget Rendering Server (PHP)
            Reporter: bruno rovagnati


when concatenating inline JS features, no NewLine was added between them, and the new opensocial7to8.js rendered like this:

// stub javascript /*
 * Licensed to the Apache Software Foundation (ASF) under one

so the comment opening was ignored and an error arises.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-322) bug when concatenating inline JS (when js compress == false)

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-322.
----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

committed, thanks!

> bug when concatenating inline JS (when js compress == false)
> ------------------------------------------------------------
>
>                 Key: SHINDIG-322
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-322
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: bruno rovagnati
>            Assignee: Chris Chabot
>         Attachments: jsloader.patch
>
>
> when concatenating inline JS features, no NewLine was added between them, and the new opensocial7to8.js rendered like this:
> // stub javascript /*
>  * Licensed to the Apache Software Foundation (ASF) under one
> so the comment opening was ignored and an error arises.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-322) bug when concatenating inline JS (when js compress == false)

Posted by "bruno rovagnati (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bruno rovagnati updated SHINDIG-322:
------------------------------------

    Attachment: jsloader.patch

this patches fixed the bug adding a "\n" between each inline JS

> bug when concatenating inline JS (when js compress == false)
> ------------------------------------------------------------
>
>                 Key: SHINDIG-322
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-322
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: bruno rovagnati
>         Attachments: jsloader.patch
>
>
> when concatenating inline JS features, no NewLine was added between them, and the new opensocial7to8.js rendered like this:
> // stub javascript /*
>  * Licensed to the Apache Software Foundation (ASF) under one
> so the comment opening was ignored and an error arises.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-322) bug when concatenating inline JS (when js compress == false)

Posted by "bruno rovagnati (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bruno rovagnati updated SHINDIG-322:
------------------------------------

    Attachment: jsloader.patch

grr, second time it happens, eclipse fault

changing patch path

> bug when concatenating inline JS (when js compress == false)
> ------------------------------------------------------------
>
>                 Key: SHINDIG-322
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-322
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: bruno rovagnati
>         Attachments: jsloader.patch
>
>
> when concatenating inline JS features, no NewLine was added between them, and the new opensocial7to8.js rendered like this:
> // stub javascript /*
>  * Licensed to the Apache Software Foundation (ASF) under one
> so the comment opening was ignored and an error arises.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-322) bug when concatenating inline JS (when js compress == false)

Posted by "bruno rovagnati (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

bruno rovagnati updated SHINDIG-322:
------------------------------------

    Attachment:     (was: jsloader.patch)

> bug when concatenating inline JS (when js compress == false)
> ------------------------------------------------------------
>
>                 Key: SHINDIG-322
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-322
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>            Reporter: bruno rovagnati
>         Attachments: jsloader.patch
>
>
> when concatenating inline JS features, no NewLine was added between them, and the new opensocial7to8.js rendered like this:
> // stub javascript /*
>  * Licensed to the Apache Software Foundation (ASF) under one
> so the comment opening was ignored and an error arises.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.