You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/11/25 07:21:10 UTC
[GitHub] [helix] rahulrane50 opened a new pull request, #2293: Reducing zk operations default retry timeout.
rahulrane50 opened a new pull request, #2293:
URL: https://github.com/apache/helix/pull/2293
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
(Write a concise description including what, why, how)
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rahulrane50 commented on pull request #2293: Reducing zk operations default retry timeout.
Posted by GitBox <gi...@apache.org>.
rahulrane50 commented on PR #2293:
URL: https://github.com/apache/helix/pull/2293#issuecomment-1331973904
Thanks @jiajunwang and @junkaixue for your comments. The rational behind reducing this default timeout is that 25 days is way too much timeout for any operation to retry IMHO. Even 1 day is long one but still it is reasonable in some sense, in reality I'm hoping that end users will override this by few mins timeout value. Let me know if that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2293: Reducing zk operations default retry timeout.
Posted by GitBox <gi...@apache.org>.
junkaixue commented on PR #2293:
URL: https://github.com/apache/helix/pull/2293#issuecomment-1331725208
I cannot remember why it set to int max. Maybe because it was timeout within the same session? @jiajunwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #2293: Reducing zk operations default retry timeout.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on PR #2293:
URL: https://github.com/apache/helix/pull/2293#issuecomment-1332558081
I don't have any concern regarding the change. Just to provide some more context:
One question we discussed before is what to do if the operation is timed out?
If users are going to manually retry anyway, then just keep retrying seems to be a reasonable choice.
Actually inside Helix control plane, retrying is the only option, IMHO.
In other systems, the timeout error state does not necessarily stop the retry process. But it seems to be too complicated for Helix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #2293: Reducing zk operations default retry timeout.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on PR #2293:
URL: https://github.com/apache/helix/pull/2293#issuecomment-1331802361
> I cannot remember why it set to int max. Maybe because it was timeout within the same session? @jiajunwang
It was not a purely technical decision. I think keeping retrying still makes sense for the control plane components. But for end users, a reasonable timeout is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2293: Reducing zk operations default retry timeout.
Posted by GitBox <gi...@apache.org>.
junkaixue commented on PR #2293:
URL: https://github.com/apache/helix/pull/2293#issuecomment-1336021001
Please make sure your mvn test result pasted in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on pull request #2293: Reducing zk operations default retry timeout.
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on PR #2293:
URL: https://github.com/apache/helix/pull/2293#issuecomment-1331103959
@junkaixue Was there any reason why the operation timeout is Integer.MAX? Is there any case we know that may exceed that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2293: Reducing zk operations default retry timeout.
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2293:
URL: https://github.com/apache/helix/pull/2293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org